gutenprint-base (and all slave ports) create empty modules directory:
it seems like this directory is not used by anything. Should it be created? If it should, should each slave create it as well? If they should, it should be listed in each slave's pkg-plist as @dir. And if it's needed, it should be created under PREFIX, not LOCALBASE
the modules directory is still referenced in the source code (being a little short on time, I did not check if that code is functional... but at least it isn't us who "invented" this directory).
I can send a quick patch for this, around next weekend, I suppose.
Created attachment 161014 [details]
fix and modernize gutenprint ports
patch relative to /usr/ports.
rollup of PRs 196321 200017 202324
Created attachment 161015 [details]
poudriere testport on gutenprint-base
Created attachment 161016 [details]
poudriere testport on gutenprint-cups
As there were patch conflicts, I rolled up the last gutenprint patches in this diff - perhaps they get committed now.
The diff is broken. Your poudriere doesn't run stage-qa which should detect more errors.
- You've removed @dir lib/gutenprint/5.2/modules, this is incorrect as it is still created
- You've changed GUTENPRINTUI2_LIBS to pkgconfig --libs gutenprint, this breaks gimp-gutenprint
- @dir lib/gutenprint/5.2/modules is still mentioned in some slave ports
I've fixed these, attached is complete patch for all gutenprint ports, which build fine. If it's Ok with you, I can commit it right away.
Created attachment 161074 [details]
Is the patch OK?
looks good to me, and doesn't fall flat on it's face (cannot test more, for lack of hardware).
Go ahead and commit :). Thanks.
A commit references this bug:
Date: Tue Sep 22 23:59:07 UTC 2015
New revision: 397598
- Make GTK2 support optional
- Fix module directory handling
- Strip libraries
- Minor fixes
PR: 196321, 200017, 202324
Submitted by: firstname.lastname@example.org, email@example.com, amdmi3@FreeBSD.org, firstname.lastname@example.org (maintainer)
Approved by: email@example.com (maintainer)