Bug 202350 - audio/mous disable WMA option for non-x86
Summary: audio/mous disable WMA option for non-x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-08-15 17:06 UTC by Sean Bruno
Modified: 2015-09-13 10:18 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (shen.elf)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer 2015-08-15 17:06:12 UTC
There is a CMake configuration error in the audio/mous cmake files or configure tools that seems to assume that 32bitness == x86 and 64bitness == x86_64 when building.  This seems to be related to the builds of the WMA support and causes build failures.


[ 39%] Building C object CMakeFiles/WmaDecoder.dir/contrib/ffmpeg-strip-wma/asf.c.o
/nxb-bin/usr/bin/cc  -DCMAKE_INSTALL_PREFIX=\"/usr/local\" -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DWmaDecoder_EXPORTS -O -pipe -mfloat-abi=softfp  -fno-strict-aliasing -Wall -O -pipe -mfloat-abi=softfp  -fno-strict-aliasing -fPIC -I/wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib -I/wrkdirs/usr/ports/audio/mous/work/mous-1.1a/sdk -isystem /usr/local/include -isystem /opt/local/include -isystem /usr/local/include/qt4 -isystem /usr/local/include/qt4/QtGui -isystem /usr/local/include/qt4/QtCore -I/wrkdirs/usr/ports/audio/mous/work/mous-1.1a    -fno-strict-aliasing -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE -o CMakeFiles/WmaDecoder.dir/contrib/ffmpeg-strip-wma/asf.c.o   -c /wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/asf.c
In file included from /wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/asf.c:24:
In file included from /wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/avformat.h:16:
In file included from /wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/avcodec.h:14:
In file included from /wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/common.h:184:
/wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/bswap.h:17:9: error: invalid output constraint '=q' in asm
        "=q" (x)        :
        ^
In file included from /wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/asf.c:24:
In file included from /wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/avformat.h:16:
In file included from /wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/avcodec.h:14:
/wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/common.h:252:12: error: invalid input constraint 'ic' in asm
         : "ic" ((uint8_t)(-s))
           ^
/wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/common.h:259:12: error: invalid input constraint 'ic' in asm
         : "ic" ((uint8_t)(-s))
           ^
/wrkdirs/usr/ports/audio/mous/work/mous-1.1a/contrib/ffmpeg-strip-wma/common.h:1127:5: error: invalid output constraint '=A' in asm
                : "=A" (l)
                  ^
4 errors generated.
*** Error code 1





Move WMA to OPTIONS_DEFAULT_i386/amd64 to allow this port to build for armv6:

Index: /usr/local/poudriere/ports/default/audio/mous/Makefile
===================================================================
--- /usr/local/poudriere/ports/default/audio/mous/Makefile	(revision 394260)
+++ /usr/local/poudriere/ports/default/audio/mous/Makefile	(working copy)
@@ -20,9 +20,9 @@
 			WAVDECODER WAVENCODER WMA
 OPTIONS_DEFAULT=	FAAC FAAD FLAC LAME CUE MAC4DECODER \
 			MPG123 NCURSES OSS QT4 TAGLIB VORBIS WAVDECODER \
-			WAVENCODER WMA
-OPTIONS_DEFAULT_amd64=	ASSEMBLY
-OPTIONS_DEFAULT_i386=	ASSEMBLY
+			WAVENCODER
+OPTIONS_DEFAULT_amd64=	ASSEMBLY WMA
+OPTIONS_DEFAULT_i386=	ASSEMBLY WMA
 
 OPTIONS_SUB=		yes
Comment 1 commit-hook freebsd_committer 2015-09-13 10:15:21 UTC
A commit references this bug:

Author: riggs
Date: Sun Sep 13 10:14:26 UTC 2015
New revision: 396805
URL: https://svnweb.freebsd.org/changeset/ports/396805

Log:
  Turn WMA into a non-default OPTION for all but i386 and amd64

  PR:		202350
  Submitted by:	sbruno@FreeBSD.org
  Approved by:	maintainer timeout

Changes:
  head/audio/mous/Makefile