Bug 202368 - www/chromium: optionally build chromedriver
Summary: www/chromium: optionally build chromedriver
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-16 17:43 UTC by Stefan Bethke
Modified: 2015-08-23 17:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)

Attachments
add option to build and install chromedriver (1.61 KB, patch)
2015-08-16 17:43 UTC, Stefan Bethke 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Bethke 2015-08-16 17:43:56 UTC 
Created attachment 159929 [details]
add option to build and install chromedriver

chromedriver (https://sites.google.com/a/chromium.org/chromedriver/) allows remote control of a Chrome instance, for example with Selenium. Google does not provide precompiled binaries for chromedriver for FreeBSD.

The attached patch adds an option to build and install chromedriver alongside Chrome.
Comment 1 Carlos J Puga Medina 2015-08-16 19:25:42 UTC 
I'm testing@work via poudriere

Thanks for your input.
Comment 2 Carlos J Puga Medina 2015-08-20 08:52:16 UTC 
It was committed into the Chromium GH repo

https://github.com/gliaskos/freebsd-chromium/compare/master%40%7B1439455884%7D...master
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-08-20 18:12:56 UTC 
A commit references this bug:

Author: rene
Date: Thu Aug 20 18:11:58 UTC 2015
New revision: 394902
URL: https://svnweb.freebsd.org/changeset/ports/394902

Log:
  - Update to 44.0.2403.155 [1]
  - Add a non-default option to install Chrome Driver [2][3]

  PR:		202368 [2]
  PR:		202370 [3]
  Submitted by:	LeFroid via GitHub [1]
  Submitted by:	stb@lassitu.de [2][3]
  MFH:		2015Q3

Changes:
  head/www/chromium/Makefile
  head/www/chromium/distinfo
  head/www/chromium/files/chrome.in
  head/www/chromium/pkg-plist
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-08-20 18:21:59 UTC 
A commit references this bug:

Author: rene
Date: Thu Aug 20 18:21:05 UTC 2015
New revision: 394903
URL: https://svnweb.freebsd.org/changeset/ports/394903

Log:
  MFH: r394902

  - Update to 44.0.2403.155 [1]
  - Add a non-default option to install Chrome Driver [2][3]

  PR:		202368 [2]
  PR:		202370 [3]
  Submitted by:	LeFroid via GitHub [1]
  Submitted by:	stb@lassitu.de [2][3]
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/www/chromium/Makefile
  branches/2015Q3/www/chromium/distinfo
  branches/2015Q3/www/chromium/files/chrome.in
  branches/2015Q3/www/chromium/pkg-plist
Comment 5 Stefan Bethke 2015-08-22 11:28:11 UTC 
Unfortunately, the version committed doesn't work.  DRIVER_MAKE_ARGS gets defined unconditionally, but is never used, and chromedriver is never built.

Something like this is needed:
Index: Makefile
===================================================================
--- Makefile	(revision 394932)
+++ Makefile	(working copy)
@@ -196,6 +196,9 @@
 		GPERF="${LOCALBASE}/bin/gperf"
 MAKE_ARGS=	-C out/${BUILDTYPE}
 DRIVER_MAKE_ARGS=chromedriver
+.if ${PORT_OPTIONS:MDRIVER}
+MAKE_ARGS+=	${DRIVER_MAKE_ARGS}
+.endif
 
 .include <bsd.port.pre.mk>
Comment 6 Rene Ladan freebsd_committer freebsd_triage 2015-08-22 11:34:11 UTC 
Can you check with r395024 I committed this morning?
Comment 7 Stefan Bethke 2015-08-23 17:37:52 UTC 
Thank you, that does the trick!