Bug 202549 - [patch] x11/xpra: pass stage-qa, drop optional runtime dependency on pulseaudio
Summary: [patch] x11/xpra: pass stage-qa, drop optional runtime dependency on pulseaudio
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-08-21 15:40 UTC by Matthew Rezny
Modified: 2015-10-20 00:12 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jkim)

Attachments
x11/xpra improvement patch (2.25 KB, patch)
2015-08-21 15:40 UTC, Matthew Rezny 		no flags Details | Diff
portlint and suggested make tests output (206.16 KB, text/plain)
2015-10-14 02:36 UTC, Matthew Rezny 		no flags Details
x11/xpra improvement patch (2.74 KB, patch)
2015-10-14 03:38 UTC, Matthew Rezny 		koobs: maintainer-approval? (jkim)
 Details | Diff
portlint and suggested make tests output (198.68 KB, text/plain)
2015-10-14 03:39 UTC, Matthew Rezny 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer freebsd_triage 2015-08-21 15:40:49 UTC 
Created attachment 160179 [details]
x11/xpra improvement patch

I had meant to make pulseaudio an option, but during a discussion of what the default state should be bapt suggested to remove the run_depend and add a pkg-message, so that is what I did.

Also, clean up these stage-qa error and warnings:
Error: 'etc/xpra/xpra.conf' is referring to /usr/obj/usr/ports/x11/xpra/work/stage
Warning: you need USES=desktop-file-utils
Warning: you need USES=shared-mime-info

The xpra.conf and xorg.xong should not be in stagedir, they are not in pkg-plist and there are the correct @sample for those, so they are deleted in post-install. The only difference between xpra.conf and its .sample was the one line triggering the error during stage-qa.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-14 02:17:25 UTC 
Matthew, can you please provide Qa results (portlint, poudriere) as attachments please.

Jung-uk, this PR is maintainer-timeout territory, please provide feedback or alternative instructions so that it can be resolved (committed or rejected)
Comment 2 Matthew Rezny freebsd_committer freebsd_triage 2015-10-14 02:36:35 UTC 
Created attachment 162005 [details]
portlint and suggested make tests output

portlint -C and output of "make stage && make check-plist && make stage-qa && make package"
Comment 3 Matthew Rezny freebsd_committer freebsd_triage 2015-10-14 03:38:12 UTC 
Created attachment 162008 [details]
x11/xpra improvement patch
Comment 4 Matthew Rezny freebsd_committer freebsd_triage 2015-10-14 03:39:17 UTC 
Created attachment 162009 [details]
portlint and suggested make tests output
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-10-20 00:11:07 UTC 
A commit references this bug:

Author: jkim
Date: Tue Oct 20 00:10:43 UTC 2015
New revision: 399796
URL: https://svnweb.freebsd.org/changeset/ports/399796

Log:
  - Update to 0.15.7.
  - Add options to allow excluding some features.
  - Pass stage-qa and remove runtime dependency for audio/pulseaudio. [1]

  PR:		202549 [1]

Changes:
  head/x11/xpra/Makefile
  head/x11/xpra/distinfo
  head/x11/xpra/files/patch-setup.py
  head/x11/xpra/pkg-message
  head/x11/xpra/pkg-plist
Comment 6 Jung-uk Kim freebsd_committer freebsd_triage 2015-10-20 00:12:00 UTC 
Committed (with some changes), thanks!