Bug 202556 - [PATCH] net-mgmt/nagios4: nagios_enable not set in rc script
Summary: [PATCH] net-mgmt/nagios4: nagios_enable not set in rc script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mathieu Arnold
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-21 21:32 UTC by John Marshall
Modified: 2015-08-31 10:08 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mat)


Attachments
Set default value "NO" for nagios_enable in rc script (378 bytes, patch)
2015-08-21 21:32 UTC, John Marshall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marshall 2015-08-21 21:32:44 UTC
Created attachment 160191 [details]
Set default value "NO" for nagios_enable in rc script

Comments at the beginning of the port's rc script say that nagios_enable is set to NO by default. This patch makes it so.

The rc script does not set a value for nagios_enable at all, so if the variable is not set in the system rc.conf, the rc system emits the following WARNING message during startup or shutdown if the port is installed but not configured:

  /usr/local/etc/rc.d/nagios: WARNING: $nagios_enable is not set properly - see rc.conf(5).

This patch modifies the port's rc script to set nagios_enable to "NO" if the variable is empty or not set in rc.conf.
Comment 1 commit-hook freebsd_committer 2015-08-31 10:06:52 UTC
A commit references this bug:

Author: mat
Date: Mon Aug 31 10:06:08 UTC 2015
New revision: 395658
URL: https://svnweb.freebsd.org/changeset/ports/395658

Log:
  Set default value "NO" for nagios_enable in rc script.

  PR:		202556
  Submitted by:	John Marshall
  Sponsored by:	Absolight

Changes:
  head/net-mgmt/nagios4/Makefile
  head/net-mgmt/nagios4/files/nagios.in