Created attachment 160230 [details]
Fix pessimizing moves in security/obfsclient
During the exp-run in bug 201377, it was found that security/obfsclient gives errors with a recent clang 3.7.0 snapshot:
This is because the program calls std::move() in a few situations where it is detrimental to performance, because moving a temporary object prevents copy elision. The attached patch removes those std::move() calls.
Thanks a lot for the report and the patch which I hereby approve.
A commit references this bug:
Date: Wed Aug 26 00:23:40 UTC 2015
New revision: 395327
Fix security/obfsclient build with clang 3.7.0.
Submitted by: dim