Bug 202675 - [PATCH] lang/go: override GOBIN in bsd.go.mk
Summary: [PATCH] lang/go: override GOBIN in bsd.go.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Julien Laffaye
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-26 13:54 UTC by Maciej Pasternacki
Modified: 2015-08-26 18:51 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jlaffaye)


Attachments
go-gobin.patch (916 bytes, patch)
2015-08-26 13:54 UTC, Maciej Pasternacki
no flags Details | Diff
bsd.go.mk-gobin.patch (444 bytes, patch)
2015-08-26 13:58 UTC, Maciej Pasternacki
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pasternacki 2015-08-26 13:54:27 UTC
Created attachment 160378 [details]
go-gobin.patch

The bsd.go.mk file provided by lang/go does not explicitly set GOBIN environment variable, which breaks if GOBIN variable already exists in environment of user that invokes make.
Comment 1 Maciej Pasternacki 2015-08-26 13:58:23 UTC
Created attachment 160379 [details]
bsd.go.mk-gobin.patch

Previously pasted version contained an unrelated change (work on #202504), this is the correct one.
Comment 2 Julien Laffaye freebsd_committer 2015-08-26 18:31:53 UTC
Setting GOBIN is discouraged since few years.
I'd prefer to unset it with GOBIN="", if you confirm that it fixes your issue.
Comment 3 Maciej Pasternacki 2015-08-26 18:42:26 UTC
Yes, clearing with GOBIN="" fixes my issue. Thank you!
Comment 4 commit-hook freebsd_committer 2015-08-26 18:50:39 UTC
A commit references this bug:

Author: jlaffaye
Date: Wed Aug 26 18:50:02 UTC 2015
New revision: 395390
URL: https://svnweb.freebsd.org/changeset/ports/395390

Log:
  Force GOBIN to the empty string.

  If GOBIN is already defined in the environment,
  it can break ports using bsd.go.mk

  PR:		202675

Changes:
  head/lang/go/files/bsd.go.mk