Bug 202677 - [PATCH] Update mail/cone to 0.92
Summary: [PATCH] Update mail/cone to 0.92
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords: patch
: 202259 203697 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-08-26 15:18 UTC by yamagi
Modified: 2015-10-28 17:26 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (uffe)


Attachments
Update to 0.92 (10.12 KB, patch)
2015-08-26 15:18 UTC, yamagi
no flags Details | Diff
svn diff for mail/cone (4.26 KB, patch)
2015-10-16 15:44 UTC, Bernard Spil
no flags Details | Diff
svn diff for mail/cone (7.87 KB, patch)
2015-10-25 14:39 UTC, Bernard Spil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yamagi 2015-08-26 15:18:53 UTC
Created attachment 160381 [details]
Update to 0.92

The attached patch updates mail/cone to version 0.92.

Changes to the application:
 - Some bugfixes
 - Support for Unicode 6.3.0
 - Fix some keybindings

Changes to the port:
 - Clang instead of GCC.
 - Remove unneeded scripts and options
 - Pet portlint
 - Really strip the installed binaries
 - files/patch-cone_cursesmessage.C is needed to compile with Clang

This update was tested with Poudriere on FreeBSD/amd64 9.3, 10.1 and 10.2. This updated supersedes bug 202259 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202259).
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2015-10-16 14:37:29 UTC
*** Bug 202259 has been marked as a duplicate of this bug. ***
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2015-10-16 15:19:39 UTC
That's a pretty big overhaul of the whole TLS implementation it seems. Checking to see if anything requires patching!
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2015-10-16 15:44:33 UTC
Created attachment 162123 [details]
svn diff for mail/cone

This is the original diff complemented with a fix for No-SSLv3 from bug #203697.

To make it build I had to patch libmail/envelope.H as well (added include for time_t)
Comment 4 Bernard Spil freebsd_committer freebsd_triage 2015-10-16 15:44:51 UTC
*** Bug 203697 has been marked as a duplicate of this bug. ***
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2015-10-16 17:19:46 UTC
(In reply to Bernard Spil from comment #3)

Thanks, I'll test it and commit once done.

Also thanks for the time_t fix, I was going to make the same thing right now, you spared me a few minutes of work! :)
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2015-10-16 17:31:40 UTC
(In reply to Bernard Spil from comment #3)

Sorry to message you again but the patch you have attached looks incomplete.

It does not contain parts which were in the old one, only patches Makefile plist and distfiles.

Maybe it's been truncated in some way, can you send it again?
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2015-10-16 17:33:41 UTC
(In reply to Guido Falsi from comment #6)

Looking at the patch, maybe you forgot to svn add/remove files?
Comment 8 Bernard Spil freebsd_committer freebsd_triage 2015-10-25 14:39:26 UTC
Created attachment 162445 [details]
svn diff for mail/cone

Sorry, I indeed forgot to svn add the new files from the original patch. Hope this is now OK!

Thanks, Bernard
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-10-28 15:46:33 UTC
A commit references this bug:

Author: madpilot
Date: Wed Oct 28 15:45:46 UTC 2015
New revision: 400398
URL: https://svnweb.freebsd.org/changeset/ports/400398

Log:
  - Update to 0.92 [1]
  - Fix build without SSLv3 [2]

  Thanks ro brnrd for providing an updated patch.

  PR:		202677 [1], 203697 [2]
  Submitted by:	yamagi at yamagi.org [1]
  Submitted by:	cpbsdmail at gmail.com [2]
  MFH:		2015Q4

Changes:
  head/mail/cone/Makefile
  head/mail/cone/distinfo
  head/mail/cone/files/patch-cone_cursesmessage.C
  head/mail/cone/files/patch-curses-cursescontainer-C.diff
  head/mail/cone/files/patch-libmail-envelope-h.diff
  head/mail/cone/files/patch-libmail_envelope.H
  head/mail/cone/files/patch-libs_tcpd_libcouriertls.c
  head/mail/cone/pkg-plist
Comment 10 Guido Falsi freebsd_committer freebsd_triage 2015-10-28 15:46:52 UTC
Committed, with minor changes. Thanks!
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-10-28 17:26:48 UTC
A commit references this bug:

Author: madpilot
Date: Wed Oct 28 17:26:42 UTC 2015
New revision: 400403
URL: https://svnweb.freebsd.org/changeset/ports/400403

Log:
  MFH: r400398

  - Update to 0.92 [1]
  - Fix build without SSLv3 [2]

  Thanks ro brnrd for providing an updated patch.

  PR:		202677 [1], 203697 [2]
  Submitted by:	yamagi at yamagi.org [1]
  Submitted by:	cpbsdmail at gmail.com [2]

  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q4/
  branches/2015Q4/mail/cone/Makefile
  branches/2015Q4/mail/cone/distinfo
  branches/2015Q4/mail/cone/files/patch-cone_cursesmessage.C
  branches/2015Q4/mail/cone/files/patch-curses-cursescontainer-C.diff
  branches/2015Q4/mail/cone/files/patch-libmail-envelope-h.diff
  branches/2015Q4/mail/cone/files/patch-libmail_envelope.H
  branches/2015Q4/mail/cone/files/patch-libs_tcpd_libcouriertls.c
  branches/2015Q4/mail/cone/pkg-plist