Bug 202684 - net/freeradius3: Fix pkg-plist with IDN option
Summary: net/freeradius3: Fix pkg-plist with IDN option
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ryan Steinmetz
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2015-08-26 22:29 UTC by amvandemore
Modified: 2017-11-12 17:03 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (zi)
koobs: merge-quarterly?


Attachments
net/freeradius3: Correctly predicate IDN in plist (1012 bytes, patch)
2016-02-27 23:18 UTC, John W. O'Brien
koobs: maintainer-approval+
Details | Diff
net/freeradius3: portlint (3.54 KB, text/plain)
2016-07-17 13:14 UTC, John W. O'Brien
no flags Details
net/freeradius3: testport with IDN=off (80.66 KB, text/plain)
2016-07-17 13:16 UTC, John W. O'Brien
no flags Details
net/freeradius3: testport with IDN=on (79.96 KB, text/plain)
2016-07-17 13:16 UTC, John W. O'Brien
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description amvandemore 2015-08-26 22:29:59 UTC
see bug 202681 for configuration which triggers issue.

gmake[2]: Leaving directory '/usr/ports/net/freeradius3/work/freeradius-server-3.0.9'
====> Compressing man pages (compress-man)
===> Staging rc.d startup script(s)
===>   Installing ldconfig configuration file
root@radius:/usr/ports/net/freeradius3 # make install clean
===>  Installing for freeradius3-3.0.9
===>   freeradius3-3.0.9 depends on file: /usr/local/bin/python2.7 - found
===>   freeradius3-3.0.9 depends on file: /usr/local/bin/perl5.20.2 - found
===>   freeradius3-3.0.9 depends on shared library: libgdbm.so - found (/usr/local/lib/libgdbm.so)
===>   freeradius3-3.0.9 depends on shared library: libtalloc.so - found (/usr/local/lib/libtalloc.so)
===>   freeradius3-3.0.9 depends on shared library: libsqlite3.so - found (/usr/local/lib/libsqlite3.so)
===>   freeradius3-3.0.9 depends on shared library: libodbc.so - found (/usr/local/lib/libodbc.so)
===>   freeradius3-3.0.9 depends on shared library: libhiredis.so - found (/usr/local/lib/libhiredis.so)
===>   freeradius3-3.0.9 depends on shared library: libjson-c.so - found (/usr/local/lib/libjson-c.so)
===>   freeradius3-3.0.9 depends on shared library: libcurl.so - found (/usr/local/lib/libcurl.so)
===>   freeradius3-3.0.9 depends on shared library: libpq.so.5 - found (/usr/local/lib/libpq.so.5)
===>   freeradius3-3.0.9 depends on shared library: libmysqlclient.so.18 - found (/usr/local/lib/mysql/libmysqlclient.so.18)
===>  Checking if freeradius3 already installed
===>   Registering installation for freeradius3-3.0.9
pkg-static: Unable to access file /usr/ports/net/freeradius3/work/stage/usr/local/lib/freeradius-3.0.9/rlm_idn.a: No such file or directory
pkg-static: Unable to access file /usr/ports/net/freeradius3/work/stage/usr/local/lib/freeradius-3.0.9/rlm_idn.la: No such file or directory
pkg-static: Unable to access file /usr/ports/net/freeradius3/work/stage/usr/local/lib/freeradius-3.0.9/rlm_idn.so: No such file or directory
*** Error code 74

Stop.
make[1]: stopped in /usr/ports/net/freeradius3
*** Error code 1
Comment 1 John W. O'Brien 2016-02-27 23:18:05 UTC
Created attachment 167490 [details]
net/freeradius3: Correctly predicate IDN in plist

I believe this bug is attributable to an error in the plist. The IDN option controls RLMIDN in PLIST_SUB, whereas the EXPM replacement is controlled by any of FIREBIRD, RUBY, REDIS, REST, FREETDS, IDN, or EXPERIMENTAL.

While here, correct copy/paste error in related Makefile comment.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-17 09:00:52 UTC
@John, can you confirm this change still passes QA (portlint, poudriere) against the port head please
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-17 09:01:30 UTC
Comment on attachment 167490 [details]
net/freeradius3: Correctly predicate IDN in plist

Maintainer timeout (5 months), implicit approval. Open to take
Comment 4 John W. O'Brien 2016-07-17 13:14:54 UTC
Created attachment 172605 [details]
net/freeradius3: portlint

portlint reports 21 warnings, none of them new for the proposed patch.
Comment 5 John W. O'Brien 2016-07-17 13:16:01 UTC
Created attachment 172606 [details]
net/freeradius3: testport with IDN=off
Comment 6 John W. O'Brien 2016-07-17 13:16:20 UTC
Created attachment 172607 [details]
net/freeradius3: testport with IDN=on
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-18 10:17:04 UTC
@John Thank you for the feedback. For future issues, confirmation of QA passing doesn't necessarily require logs unless specifically requested. The following is sufficient:

portlint: OK (looks fine.)
porttest: OK (poudriere: <archs>, <versions>, <OPTIONS> tested)
Comment 8 Bartek Rutkowski freebsd_committer freebsd_triage 2016-12-02 17:31:10 UTC
This patch generates huge amount of portlint warnings, could you fix the patch and update it?
Comment 9 John W. O'Brien 2016-12-11 15:33:42 UTC
(In reply to Bartek Rutkowski from comment #8)

The patch generates no new portlint warnings.
Comment 10 Bartek Rutkowski freebsd_committer freebsd_triage 2016-12-12 09:20:16 UTC
(In reply to John W. O'Brien from comment #9)

The portlint shows 24 warnings. It doesn't really matter if it is due to the patch or not, the port should be kept in good condition, and if you're sending a patch, you might as well include fixes for all these issues.
Comment 11 Ryan Steinmetz freebsd_committer freebsd_triage 2017-11-12 17:03:08 UTC
Build with/without IDN was fixed via this commit from 7/17/17:

https://svnweb.freebsd.org/ports/head/net/freeradius3/pkg-plist?r1=442287&r2=446076