Bug 202744 - [PATCH] graphics/qgis: Drop USES=iconv:wchar_t.
Summary: [PATCH] graphics/qgis: Drop USES=iconv:wchar_t.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-29 11:39 UTC by Raphael Kubo da Costa
Modified: 2015-08-30 10:19 UTC (History)
1 user (show)

See Also:
rhurlin: maintainer-feedback+

Attachments
Proposed patch (598 bytes, patch)
2015-08-29 11:39 UTC, Raphael Kubo da Costa 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-08-29 11:39:41 UTC 
Created attachment 160482 [details]
Proposed patch

The port has a FindIconv.cmake, but it is not used anywhere, nor does the code actually call any iconv() functions. Built fine on 10.1-amd64.
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2015-08-30 07:27:55 UTC 
Hi Raphael, Thanks for the hint.

It seems, that iconv is only needed on Windows with OSGEO4W nowadays?

I tried your patch on poudriere with 9.3, 10.2 and HEAD and all went fine. It also works quite nice without USES=iconv.

So it would be nice if you could commit the patch, thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-08-30 10:19:07 UTC 
A commit references this bug:

Author: rakuco
Date: Sun Aug 30 10:18:29 UTC 2015
New revision: 395606
URL: https://svnweb.freebsd.org/changeset/ports/395606

Log:
  Drop USES=iconv:wchar_t.

  The port has a FindIconv.cmake, but it is not used anywhere, nor does the
  code actually call any iconv() functions.

  PR:		202744
  Approved by:	Rainer Hurling <rhurlin@gwdg.de> (maintainer)

Changes:
  head/graphics/qgis/Makefile