Bug 202756 - security/cyrus-sasl2-gssapi not honouring options settings
Summary: security/cyrus-sasl2-gssapi not honouring options settings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Hajimu UMEMOTO
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-29 17:07 UTC by Phil
Modified: 2015-10-01 16:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ume)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Phil 2015-08-29 17:07:03 UTC
Problem is that variables are not honoured when set/unset when they should be:
# make showconfig
===> The following configuration options are available for cyrus-sasl-gssapi-2.1.26_3:
====> Kerberos support: you have to select exactly one of them
     BASE=on: Use Heimdal in base
     HEIMDAL=off: Use Heimdal from ports
     MIT=off: Use MIT Kerberos V5
===> Use 'make config' to modify these settings

However these are set in make.conf as demonstrated
cd /usr/ports/security/cyrus-sasl2-gssapi && make -Vsecurity_cyrus-sasl-gssapi_UNSET -Vsecurity_cyrus-sasl-gssapi_SET showconfig
BASE 
HEIMDAL 
That is BASE is UNSET and HEIMDAL is SET, because I want to use the heimdal port.
Comment 1 Hajimu UMEMOTO freebsd_committer 2015-08-29 18:11:14 UTC
It seems working well here with following lines in my make.conf:

    security_cyrus-sasl2-gssapi_SET=HEIMDAL
    security_cyrus-sasl2-gssapi_UNSET=BASE

It seems you set security_cyrus-sasl-gssapi_(UN)?SET.  Since the PKGORIGIN of cyrus-sasl2-gssapi is security/cyrus-sasl2-gssapi, you need to set security_cyrus-sasl-gssapi_(UN)?SET.
Comment 2 Hajimu UMEMOTO freebsd_committer 2015-08-29 18:13:48 UTC
Oops, typo.  You need to set security_cyrus-sasl2-gssapi_(UN)?SET.
Comment 3 Phil 2015-09-12 09:04:06 UTC
(In reply to Hajimu UMEMOTO from comment #2)
True, but we use automated scripts to manage the port options settings.  As such the "problem" is:
# pwd
/usr/ports/security/cyrus-sasl2-gssapi
# make -V PKGBASE
cyrus-sasl-gssapi

Please NOTE that it doesn't have cyrus-sasl2-gssapi which 
make -V UNIQUENAME
used to produce, and which 
make -V PKGBASE 
should

Similarly
# cd /usr/ports/security/cyrus-sasl2
# make -V PKGBASE
cyrus-sasl
# make -V UNIQUENAME

#

Something is definately broken or changed and not in /usr/ports/UPDATING for cyrus-sasl.  I examined other ports that contained numbers and they function as expected, one example:
# cd /usr/ports/net/isc-dhcp43-server && make -V PKGBASE
isc-dhcp43-server
Comment 4 Phil 2015-09-12 09:11:02 UTC
(In reply to Phil from comment #3)
The "fix" for cyrus-sasl2-gssapi

--- Makefile.broken     2015-09-12 19:11:11.000000000 +1000
+++ Makefile    2015-09-12 19:11:11.000000000 +1000
@@ -6,7 +6,7 @@
 CATEGORIES=    security ipv6
 MASTER_SITES=  ftp://ftp.cyrusimap.org/cyrus-sasl/ \
                http://cyrusimap.org/releases/
-PKGNAMEPREFIX= cyrus-sasl-
+PKGNAMEPREFIX= cyrus-sasl2-
 DISTNAME=      ${PKGNAMEPREFIX}${PORTVERSION}

 MAINTAINER=    ume@FreeBSD.org


Similarly for security/cyrus-sasl2
Comment 5 commit-hook freebsd_committer 2015-10-01 15:58:29 UTC
A commit references this bug:

Author: ume
Date: Thu Oct  1 15:58:09 UTC 2015
New revision: 398328
URL: https://svnweb.freebsd.org/changeset/ports/398328

Log:
  Sync package name with origin.

  PR:		202756

Changes:
  head/security/cyrus-sasl2/Makefile
  head/security/cyrus-sasl2-gssapi/Makefile
  head/security/cyrus-sasl2-ldapdb/Makefile
  head/security/cyrus-sasl2-saslauthd/Makefile
Comment 6 Hajimu UMEMOTO freebsd_committer 2015-10-01 16:07:19 UTC
I think there is no such rule to be in sync package name with origin.
However, it is better to sync them.  So, I've just commit the changes.
Thank you for the suggestion.