Bug 202759 - [PATCH] cad/openvsp: Drop USES=iconv.
Summary: [PATCH] cad/openvsp: Drop USES=iconv.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-29 21:34 UTC by Raphael Kubo da Costa
Modified: 2015-08-30 17:41 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (fernape)


Attachments
Proposed patch (596 bytes, patch)
2015-08-29 21:34 UTC, Raphael Kubo da Costa
no flags Details | Diff
poudriere log on 9.3-RELEASE-amd64 (204.09 KB, text/x-log)
2015-08-30 17:14 UTC, Fernando Apesteguía
no flags Details
poudriere log on 10.2-RELEASE-amd64 (216.96 KB, text/x-log)
2015-08-30 17:14 UTC, Fernando Apesteguía
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer 2015-08-29 21:34:44 UTC
Created attachment 160501 [details]
Proposed patch

The port does not use iconv anywhere, and the dependency on libxml2 does not pull any headers that include iconv.h.

Tested on 9.3-i386, 10.1-amd64 and 11-amd64.
Comment 1 Fernando Apesteguía freebsd_committer 2015-08-30 17:14:36 UTC
Created attachment 160532 [details]
poudriere log on 9.3-RELEASE-amd64
Comment 2 Fernando Apesteguía freebsd_committer 2015-08-30 17:14:54 UTC
Created attachment 160533 [details]
poudriere log on 10.2-RELEASE-amd64
Comment 3 Fernando Apesteguía freebsd_committer 2015-08-30 17:16:07 UTC
(In reply to Raphael Kubo da Costa from comment #0)

I complement your tests with poudriere logs for {9.3,10.2}amd64

You have my approval and thanks for the heads up.
Comment 4 commit-hook freebsd_committer 2015-08-30 17:41:41 UTC
A commit references this bug:

Author: rakuco
Date: Sun Aug 30 17:41:24 UTC 2015
New revision: 395630
URL: https://svnweb.freebsd.org/changeset/ports/395630

Log:
  Drop USES=iconv.

  The port does not use iconv anywhere, and the dependency on libxml2 does not
  pull any headers that include iconv.h.

  PR:		202759
  Approved by:	fernando.apesteguia@gmail.com (maintainer)

Changes:
  head/cad/openvsp/Makefile