Bug 203006 - lang/go: trivial adjustment to support DragonFly out-of-the-box
Summary: lang/go: trivial adjustment to support DragonFly out-of-the-box
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-10 08:23 UTC by John Marino
Modified: 2015-09-10 23:00 UTC (History)
0 users

See Also:
jlaffaye: maintainer-feedback+


Attachments
Patch lang/go to enhance pkg-plist and bsd.go.mk to support DragonFly (20.91 KB, patch)
2015-09-10 08:24 UTC, John Marino
no flags Details | Diff
Poudriere build log (18.15 KB, text/plain)
2015-09-10 08:25 UTC, John Marino
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer 2015-09-10 08:23:12 UTC
The pkg-plist and bsd.go.mk have been unnecessarily hardcoded to "freebsd".  The attached patch enhances the PLIST_SUB variable so that it will build out of the box on DragonFly.

I've been carrying an equivalent patch in DPorts, but every release of go completely breaks it, so it would be great to get this adjustment in.  If approved, I can commit it.

I'm also going to attach a poudriere log to prove the port still builds fine on FreeBSD.
Comment 1 John Marino freebsd_committer 2015-09-10 08:24:39 UTC
Created attachment 160887 [details]
Patch lang/go to enhance pkg-plist and bsd.go.mk to support DragonFly

Strange, the patch didn't attach when I created the PR.
Comment 2 John Marino freebsd_committer 2015-09-10 08:25:41 UTC
Created attachment 160888 [details]
Poudriere build log

Attaching poudriere log to show port still works on FreeBSD after patch applied.
Comment 3 commit-hook freebsd_committer 2015-09-10 22:57:52 UTC
A commit references this bug:

Author: marino
Date: Thu Sep 10 22:57:48 UTC 2015
New revision: 396626
URL: https://svnweb.freebsd.org/changeset/ports/396626

Log:
  lang/go: adjust PLIST_SUB and bsd.go.mk to support DragonFly

  Change hardcoded "freebsd" to variable (OPSYS:tl) to allow DragonFly
  to build without patches.

  PR:		203006
  Approved by:	maintainer

Changes:
  head/lang/go/Makefile
  head/lang/go/files/bsd.go.mk
  head/lang/go/pkg-plist