Bug 203055 - Moved or new file contents not included in diff via arc(8)
Summary: Moved or new file contents not included in diff via arc(8)
Status: Closed FIXED
Alias: None
Product: Services
Classification: Unclassified
Component: Code Review (show other bugs)
Version: unspecified
Hardware: Any Any
: Normal Affects Many People
Assignee: Phabric Admin
URL: https://reviews.freebsd.org/D3234
Keywords: dogfood, needs-qa, regression
: 204206 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-12 10:08 UTC by Jean-Sébastien Pédron
Modified: 2016-02-13 14:54 UTC (History)
5 users (show)

See Also:

Attachments
Fix the arcanist binary_safe_diff script to preserve diff's exit code (1015 bytes, patch)
2015-12-12 21:03 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-09-12 10:08:47 UTC 
Copnsider the following review:
https://reviews.freebsd.org/D3234

In diff #6, a patch was copied from lang/rust/files to lang/rust-nightly/files in my Subversion working copy (using svn cp). The file is listed in the review's ToC. However, the raw diff, downloaded from the upper right corner, does not contain this new file.
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2015-10-21 04:25:13 UTC 
Is this still an issue?  How was the diff created (manually uploaded? 'arc diff')
Comment 2 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-10-21 07:11:40 UTC 
Hi Eitan!

I don't know if this is still a problem as I didn't uploaded a new diff with a moved file recently.

The diff was created with "arc diff".
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2015-10-21 14:47:26 UTC 
Just hit this issue as well. https://reviews.freebsd.org/D3953

The raw diff when applied using `patch` the files are emptied in mariadb- and the new mariadb53- directories are not created. After renaming the mariadb- folders to mariadb53 and applying the patch it works as expected.

Next to that, the creation of files for the mariadb101- ports shows "Hunk succeeded" yet no file/directory is created.

Can the patches only be applied to svn repos using `svn patch`?

Thanks!

Bernard.
Comment 4 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-11-02 10:24:25 UTC 
This happens for new files too, not only moves/renames. See:
https://reviews.freebsd.org/D4058
Comment 5 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-11-02 10:25:20 UTC 
*** Bug 204206 has been marked as a duplicate of this bug. ***
Comment 6 Steven Hartland freebsd_committer freebsd_triage 2015-12-12 03:33:44 UTC 
Yer have filed a bug with phabricator here:
https://secure.phabricator.com/T9970
Comment 7 Steven Hartland freebsd_committer freebsd_triage 2015-12-12 03:35:24 UTC 
Have tried with arc port: php5-arcanist-20150626_2 and from phabricators git version hash: dae2f0073f019221839924b4b1431c6cba5dcddaESC
Comment 8 Dimitry Andric freebsd_committer freebsd_triage 2015-12-12 20:45:04 UTC 
See my proposed fix here: https://secure.phabricator.com/D14755
Comment 9 Dimitry Andric freebsd_committer freebsd_triage 2015-12-12 21:03:22 UTC 
Created attachment 164158 [details]
Fix the arcanist binary_safe_diff script to preserve diff's exit code
Comment 11 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2016-02-13 14:54:38 UTC 
I can't reproduce this problem anymore, so an update to our Phabricator must have fixed this.

Thank you!