Bug 203069 - misc/ttyrec: enable OPENPTY by default
Summary: misc/ttyrec: enable OPENPTY by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-13 15:51 UTC by Steve Wills
Modified: 2016-04-04 14:49 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (lippe)


Attachments
patch to enable openpty by default (482 bytes, patch)
2015-09-13 15:51 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2015-09-13 15:51:04 UTC
Created attachment 160970 [details]
patch to enable openpty by default

ttyrec doesn't seem to work without the OPENPTY option, so lets enable it by default. Not sure if this is only needed on certain versions of FreeBSD, so leaving it like this for now. More testing would be appreciated.
Comment 1 Joseph Mulloy 2015-09-13 16:20:19 UTC
I found that ttyrec does work if I do "kldload pty". However since it seems that we should be moving from pty to openpty this option should be either defaulted to ON or removed.

https://svnweb.freebsd.org/base?view=revision&revision=233271
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2015-11-08 15:06:06 UTC
lippe@'s commit bit has been taken for safekeeping.  Assign to submitter.
Comment 3 Olivier Cochard freebsd_committer freebsd_triage 2016-03-31 14:02:21 UTC
Oops, didn't see this PR before.
ttyrec was updated for enabling OPENPTY by default:
https://svnweb.freebsd.org/ports?view=revision&revision=412210