Bug 203160 - Fix devel/codeblocks build with clang 3.7.0
Summary: Fix devel/codeblocks build with clang 3.7.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks: 201377
  Show dependency tree / graph
 
Reported: 2015-09-16 20:01 UTC by Dimitry Andric
Modified: 2015-12-22 15:24 UTC (History)
2 users (show)

See Also:

Attachments
Fix devel/codeblocks build with clang 3.7.0 (3.32 KB, patch)
2015-09-16 20:01 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer 2015-09-16 20:01:28 UTC 
Created attachment 161124 [details]
Fix devel/codeblocks build with clang 3.7.0

During the exp-run in bug 201377, it was found that devel/codeblocks gives errors with clang 3.7.0:

http://package18.nyi.freebsd.org/data/headamd64PR201377-default/2015-09-16_07h08m17s/logs/errors/codeblocks-13.12_4.log

This is because cbthreadpool.h uses throw(), which should be replaced with noexcept for C++11.  In the attached patch, I have made this conditional on whether the noexcept feature is available.

Additionally, I disabled the -Wundefined-bool-conversion warning, since it happens quite a lot of times in Code::Blocks, and it seems too much churn to fix.
Comment 1 commit-hook freebsd_committer 2015-12-22 15:23:21 UTC 
A commit references this bug:

Author: miwi
Date: Tue Dec 22 15:22:48 UTC 2015
New revision: 404241
URL: https://svnweb.freebsd.org/changeset/ports/404241

Log:
  - Fix build with clang 3.7.0

  PR:		203160
  Submitted by:	dim
  Approved by:	mat (mentor)
  Differential Revision:	D4653

Changes:
  head/devel/codeblocks/Makefile
  head/devel/codeblocks/files/
  head/devel/codeblocks/files/patch-src__include__cbthreadpool.h