Bug 203196 - devel/flyspray: modernize vardir handling
Summary: devel/flyspray: modernize vardir handling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-18 17:37 UTC by Dmitry Marakasov
Modified: 2015-09-20 22:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nick)


Attachments
Patch (2.49 KB, patch)
2015-09-18 17:37 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-09-18 17:37:16 UTC
Created attachment 161171 [details]
Patch

- Only use DOCS-related pkg-message when DOCS are enabled
- Switch vardir creation from pkg-install script to @dir
- Use options helpers
Comment 1 Nick Hilliard 2015-09-20 21:02:36 UTC
it's been several years since I've used flyspray.  If you want to take over the maintainership, please feel free.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-09-20 21:35:15 UTC
(In reply to Nick Hilliard from comment #1)
> If you want to take over the maintainership, please feel free.

I actually don't. Should I reset the maintainer though? It would still be nice if you could review the patch.
Comment 3 Nick Hilliard 2015-09-20 21:37:35 UTC
the patch looks fine but I haven't tested it.  Yes, please reset the maintainer, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-09-20 22:26:40 UTC
A commit references this bug:

Author: amdmi3
Date: Sun Sep 20 22:26:09 UTC 2015
New revision: 397470
URL: https://svnweb.freebsd.org/changeset/ports/397470

Log:
  - Only use DOCS-related pkg-message when DOCS are enabled
  - Switch vardir handling from pkg-install script to @dir
  - Use options helpers
  - Add NO_ARCH
  - Reset maintainer by his own request

  PR:		203196
  Submitted by:	amdmi3
  Approved by:	nick@foobar.org (maintainer)

Changes:
  head/devel/flyspray/Makefile
  head/devel/flyspray/files/pkg-install.in
  head/devel/flyspray/pkg-plist