Created attachment 161589 [details]
polyml currently uses "-lstdc++" in configure (which is no longer available with recent llvm); also, exposing polyml as a shared library (as required by e.g. HOL4) is not enabled.
The attached patch removes "-lstdc++" from configure; also it passed "--enable-shared" to configure, such that the shared object is built.
Also, libpolyml.so[.6[.0.0]] are added to pkg-plist.
Created attachment 161590 [details]
I will test this patch when I get home from work.
any remarks? I'm using this successfully on a CURRENT which is a week old (llvm 3.6.1)
Sorry about the delay, the patch works correctly on my system. I was able to build and install the port and compiled a small SML file without issues.
@Hannes, could you obsolete the existing patches (Click Details -> Edit Details -> Tock [ ] Obsolete) and replace them with a single unified diff against the port please (you may use svn diff or diff -u)
@Bayert, we'll also need maintainer-approval (+) on that attachment once thats done. If you can't set the flag, just add the following in a comment:
Attachment <id> is approved
Created attachment 162231 [details]
single unified diff
@koobs I added a single unified diff, and obsoleted the others.
Thank you Hannes :) Can you confirm this passes QA (portlint, poudriere) ?
Comment on attachment 162231 [details]
single unified diff
Pending maintainer approval
WARN: Makefile: : the options to USES are not sorted. Please consider sorting them.
0 fatal errors and 1 warning found.
poudriere builds fine, and the resulting package works!
Would you like to address the portlint warning, or leave it till nextime?
Out of scope for this patch. It was there before, the patch doesn't touch USES.
While we're waiting for maintainer-approval anyway ;)
We're not waiting for anything: maintainer had approved adding of `--enable-shared' to CONFIGURE_ARGS, any remaining build fallout and infrastructure-related changes are our pain. I'll handle it.
A commit references this bug:
Date: Fri Oct 23 17:24:12 UTC 2015
New revision: 400041
- Allow exposing polyml as a shared library (as required by e.g. HOL4)
- Strip installed library as advised by portlint(1)
- While here, sort knobs and remove useless .include <bsd.port.options.mk>
Approved by: maintainer
Committed as ports r400041, thank you for submission!