Bug 203474 - www/helma: fix build as non-root, helpers
Summary: www/helma: fix build as non-root, helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bernhard Froehlich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-01 16:14 UTC by Dmitry Marakasov
Modified: 2015-10-23 17:48 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (decke)


Attachments
Patch (7.45 KB, patch)
2015-10-01 16:14 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-01 16:14:49 UTC
Created attachment 161605 [details]
Patch

- Handle permissions in pkg-plist instead of CHOWNing from the makefile which breaks packaging from non-root
- Use options helpers
- Add NO_ARCH


- I've removed rm -rf, I actually am not sure that anyone would want to lose logs/database on package update
- @exec ln -sf %D/%%JAVAJARDIR%%/mysql-connector-java.jar %D/%%DATADIR%%/lib/ext/mysql-connector-java.jar looks fishy, it trues to create link where file resides. If mysql-connector-java.jar is needed in %%JAVAJARDIR%%, it may be copied/moved/linked from the Makefile.
- I doubt whole WWW dir should be owner by www - this is a security hole. Only writable files/dirs should, if any.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-10-23 17:48:22 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Oct 23 17:48:18 UTC 2015
New revision: 400044
URL: https://svnweb.freebsd.org/changeset/ports/400044

Log:
  - Handle permissions in pkg-plist instead of CHOWNing from the makefile which breaks packaging from non-root
  - Use options helpers
  - Add NO_ARCH

  PR:		203474
  Submitted by:	amdmi3
  Approved by:	maintainer timeout (decke, 3 weeks)

Changes:
  head/www/helma/Makefile
  head/www/helma/pkg-plist