Bug 203477 - multimedia/ffmpeg: convert the rest into options helpers
Summary: multimedia/ffmpeg: convert the rest into options helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-10-01 17:58 UTC by Jan Beich
Modified: 2015-10-12 05:51 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)


Attachments
v0 (4.12 KB, patch)
2015-10-01 17:58 UTC, Jan Beich
no flags Details | Diff
QA: poudriere bulk -t -j 93i386 (233.60 KB, text/plain)
2015-10-01 17:59 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2015-10-01 17:58:44 UTC
Created attachment 161608 [details]
v0

Let's rely on variables expanding lazily in order to kill |.include <bsd.port.pre.mk>| line. While here:

- WANT_* are vestige before bsd.port.options.mk existed
- COPYTREE_* macros always create destination directory
- some redundancy:

  DOC_DOCFILES+=	*.html
  ...
  DOC_DOCFILES+=	ffserver.html
  ...
  DOC_DOCFILES+=	ffplay.html
Comment 1 Jan Beich freebsd_committer 2015-10-01 17:59:30 UTC
Created attachment 161609 [details]
QA: poudriere bulk -t -j 93i386
Comment 2 commit-hook freebsd_committer 2015-10-12 05:42:18 UTC
A commit references this bug:

Author: riggs
Date: Mon Oct 12 05:42:11 UTC 2015
New revision: 399112
URL: https://svnweb.freebsd.org/changeset/ports/399112

Log:
  Use OPTION helpers for the remaining OPTIONs

  PR:		203477
  Submitted by:	jbeich@FreeBSD.org

Changes:
  head/multimedia/ffmpeg/Makefile