Bug 203491 - textproc/uim-gtk3: fix stage-qa
Summary: textproc/uim-gtk3: fix stage-qa
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: MANTANI Nobutaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-01 20:16 UTC by Dmitry Marakasov
Modified: 2015-10-23 16:31 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (nobutaka)


Attachments
Patch (669 bytes, patch)
2015-10-01 20:16 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2015-10-01 20:16:06 UTC
Created attachment 161623 [details]
Patch

textproc/uim-gtk3 does not deinstall cleanly

http://poudriere.amdmi3.ru/data/10-amd64-default/failures_all_2015_09_28/logs/errors/uim-gtk3-1.8.6_2.log

The difference is a single extra newline at the end of cache file.

To fix this, use `gtk-query-immodules-3.0 --update-cache` instead of `gtk-query-immodules-3.0 > %D/lib/gtk-3.0/%%GTK3_VERSION%%/immodules.cache`

- It does the same thing
- It doesn't add an extra line, fixing stage-qa
- It's shorter and doesn't need to know cache file location
- That's what gtk30 and other port do
Comment 1 commit-hook freebsd_committer 2015-10-23 16:31:08 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Oct 23 16:30:53 UTC 2015
New revision: 400034
URL: https://svnweb.freebsd.org/changeset/ports/400034

Log:
  - Implement clean deinstallation

  PR:		203491
  Submitted by:	amdmi3
  Approved by:	maintainer timeout (nobutaka, 3 weeks)

Changes:
  head/textproc/uim-gtk3/pkg-plist