Bug 203664 - [MAINTAINER] games/minecraft-server: Add new rc.conf option
Summary: [MAINTAINER] games/minecraft-server: Add new rc.conf option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-09 20:00 UTC by Jonathan Price
Modified: 2015-10-15 14:15 UTC (History)
0 users

See Also:


Attachments
Patch File (2.89 KB, patch)
2015-10-09 20:00 UTC, Jonathan Price
freebsd: maintainer-approval+
Details | Diff
portlint -A output (684 bytes, text/plain)
2015-10-09 20:01 UTC, Jonathan Price
freebsd: maintainer-approval+
Details
Poudriere testport log (21.20 KB, text/plain)
2015-10-09 20:01 UTC, Jonathan Price
freebsd: maintainer-approval+
Details
Revised patch file (handles deprecation) (3.13 KB, patch)
2015-10-14 17:18 UTC, Jonathan Price
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Price 2015-10-09 20:00:56 UTC
Created attachment 161861 [details]
Patch File

portlint -A output and poudriere testport output files have been attached, in addition to the patch itself.

The patch has been tested on both a new and an existing installation, with no immediate issues discovered.
Comment 1 Jonathan Price 2015-10-09 20:01:39 UTC
Created attachment 161862 [details]
portlint -A output
Comment 2 Jonathan Price 2015-10-09 20:01:58 UTC
Created attachment 161863 [details]
Poudriere testport log
Comment 3 Mathieu Arnold freebsd_committer 2015-10-14 12:05:50 UTC
Shouldn't there be some warning or compat shims for users who have minecraft_mem set, as the value will be ignored now.
Comment 4 Mathieu Arnold freebsd_committer 2015-10-14 12:07:54 UTC
Also, as a side note, is there some document somewhere asking you to attach portlint and poudriere logs ? As nobody will ever read them, all it does is fill up the bug tracker...
Comment 5 Jonathan Price 2015-10-14 16:33:03 UTC
(In reply to Mathieu Arnold from comment #3)

Ah, yes. I do apologise, it didn't occur to me that I should provide a warning for the deprecated value. I will re-work the patch to make it do the same as the new memx for now, and provide a warning.

As for the poudriere testport and portlint -A, I was asked to do this by Kubilay Kocak here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196169#c5

Being that both you and him are committers, I am not sure who to follow regarding whether or not I post the extra files.
Comment 6 Jonathan Price 2015-10-14 17:18:20 UTC
Created attachment 162045 [details]
Revised patch file (handles deprecation)
Comment 7 Mathieu Arnold freebsd_committer 2015-10-15 12:40:09 UTC
(In reply to Jonathan Price from comment #5)
> As for the poudriere testport and portlint -A, I was asked to do this by
> Kubilay Kocak here:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196169#c5
> 
> Being that both you and him are committers, I am not sure who to follow
> regarding whether or not I post the extra files.

Mmmm, well, you have to run portlint and poudriere testport before submitting a patch, but you don't need to attach the log files, saying things like "portlint -A is ok with it" (or "portlint is being stupid about X, which is fine") and "builds fine in poudriere on 9 and 10" is enough, nobody will ever read the log files :-)
Comment 8 commit-hook freebsd_committer 2015-10-15 14:15:12 UTC
A commit references this bug:

Author: mat
Date: Thu Oct 15 14:14:21 UTC 2015
New revision: 399340
URL: https://svnweb.freebsd.org/changeset/ports/399340

Log:
  Allow to use different values for -Xmx and -Xms in the rc script. [1]

  Cleanup.

  PR:		203664 [1]
  Submitted by:	maintainer [1]
  Sponsored by:	Absolight

Changes:
  head/games/minecraft-server/Makefile
  head/games/minecraft-server/files/minecraft.in
  head/games/minecraft-server/files/pkg-message.in
  head/games/minecraft-server/pkg-plist