Bug 203673 - [patch] [libxo]: resolve 'undefined reference to `humanize_number`'
Summary: [patch] [libxo]: resolve 'undefined reference to `humanize_number`'
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Enji Cooper
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-10-10 10:05 UTC by Andriy Voskoboinyk
Modified: 2015-10-24 23:28 UTC (History)
2 users (show)

See Also:

Attachments
Makefile.diff (321 bytes, patch)
2015-10-10 10:07 UTC, Andriy Voskoboinyk 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-10-10 10:05:06 UTC 
Since contrib/libxo/libxo/libxo.c uses it, add LIBADD+=	util to lib/libxo/Makefile.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-10-10 10:07:46 UTC 
Created attachment 161870 [details]
Makefile.diff
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2015-10-11 09:02:27 UTC 
Notify most prolific committers to this file.
Comment 3 Enji Cooper freebsd_committer freebsd_triage 2015-10-16 00:06:27 UTC 
Taking.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-10-18 07:31:38 UTC 
A commit references this bug:

Author: ngie
Date: Sun Oct 18 07:30:51 UTC 2015
New revision: 289490
URL: https://svnweb.freebsd.org/changeset/base/289490

Log:
  Make libxo depend on libutil because it uses humanize_number after r287111

  Remove overlinking in lib/libxo/tests, sbin/savecore, and
  usr.bin/{iscsictl,wc,xo}

  PR: 203673
  Sponsored by: EMC / Isilon Storage Division

Changes:
_U  head/
  head/bin/ps/Makefile
  head/lib/libxo/Makefile
  head/lib/libxo/tests/Makefile
  head/lib/libxo/tests/encoder/Makefile
_U  head/sbin/
  head/sbin/savecore/Makefile
_U  head/share/
  head/share/mk/src.libnames.mk
  head/usr.bin/iscsictl/Makefile
  head/usr.bin/wc/Makefile
  head/usr.bin/xo/Makefile
Comment 5 Enji Cooper freebsd_committer freebsd_triage 2015-10-24 23:28:55 UTC 
As far as I know, libxo will never be MFCed to an earlier release. Closing bug.