Created attachment 162024 [details] New patchfile, to be added to PORTDIR/files/ This is one of the ports affected by the gettext-related issue that breaks builds on 9.X-RELEASE (but not 10.X), as reported by pkg-fallout. The attached patchfile (generated with "make makepatch") can be added to the port's files/ directory. If a patch for the entire port directory is preferred (i.e. "cd /usr/ports/x11-servers && diff -ruN Xfstt.orig Xfstt") I can submit that as well. As far as I can tell, this fix doesn't require PORTREVISION to be set/bumped.
Created attachment 162025 [details] Patch for entire port directory This patch can be applied against the ports directory, in case that's easier than adding the previous file. Note that this patch doesn't obsolete the previous patchfile: EITHER add the previous patchfile to the files/ directory OR apply this patch to the port's directory; whichever is easier.
@AJ, for future references, single (unified svn diff) patch that is maintainer approved is preferred, with all others (previous, outdated, unapproved, etc) obsoleted Failing the obsoletion, committers will (or should) normally choose the latest maintainer-approval (+) attachment. QA results (portlint/poudriere) are still needed for this issue
Sorry I forgot the logs! Build logs ("make stage && make check-plist && make stage-qa && make package") for... 9.X i386: https://www.skysmurf.nl/~fonz/attic/Xfstt_9X_i386.log (So that's fixed.) 10.X amd64: https://www.skysmurf.nl/~fonz/attic/Xfstt_10X_amd64.log (So 10.X remains unaffected.) Portlint output: # env DEVELOPER=yes portlint -A . WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. 0 fatal errors and 1 warning found. @Koobs: So if I understand correctly the second attachment is the right way?
Also: if you don't trust the self-signed certificate use http://... instead of https://...
Thanks for the patch. As a side note, you don't need to provide poudriere logs, saying "builds fine on 9 and 10" is enough. (same for portlint)
A commit references this bug: Author: mat Date: Fri Oct 16 14:19:08 UTC 2015 New revision: 399478 URL: https://svnweb.freebsd.org/changeset/ports/399478 Log: Fix build on 9. PR: 203766 Submitted by: maintainer Sponsored by: Absolight Changes: head/x11-servers/Xfstt/files/patch-po_Makefile.in.in
Can this please be merged into -quarterly?
Re-open for MFH
Forgotten to close?