Bug 203880 - [patch] databases/libmemcached: Missing stdarg.h
Summary: [patch] databases/libmemcached: Missing stdarg.h
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-10-19 19:28 UTC by Olivier - interfaSys sàrl
Modified: 2015-12-25 01:54 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
Adss missing stdarg.h (821 bytes, patch)
2015-10-19 19:28 UTC, Olivier - interfaSys sàrl
koobs: maintainer-approval? (m.tsatsenko)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier - interfaSys sàrl 2015-10-19 19:28:06 UTC
Created attachment 162217 [details]
Adss missing stdarg.h

FreeBSD 9.3, GCC4.9

Compilation fails
------
clients/ms_task.c:460:19: warning: unused variable 'item' [-Wunused-variable]
   ms_task_item_t *item= task->item;
                   ^
  CC       clients/ms_thread.o
  CXX      clients/generator.o
  CXX      clients/execute.o
  CXXLD    clients/memaslap
  CXX      libtest/libtest_unittest-unittest.o
In file included from ./libtest/test.hpp:69:0,
                 from ./libtest/yatl.h:43,
                 from libtest/unittest.cc:39:
./libtest/exception.hpp:83:13: error: 'va_list' has not been declared
   void init(va_list);
             ^
Makefile:7617: recipe for target 'libtest/libtest_unittest-unittest.o' failed
gmake[1]: *** [libtest/libtest_unittest-unittest.o] Error 1
gmake[1]: Leaving directory '/usr/ports/databases/libmemcached/work/libmemcached-1.0.18'
Makefile:3712: recipe for target 'all' failed
gmake: *** [all] Error 2
===> Compilation failed unexpectedly.
-------

The included patch fixes the situation
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-20 03:59:09 UTC
@Olivier, did this patch come from upstream? If so/not, can you add references to where it was obtained from?
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-20 04:00:54 UTC
@Olivier, also:

 * Does libmemcached fail to build on other FreeBSD versions without this patch?
 * Has this patch been tested for regressions on other FreeBSD versions?
Comment 3 Olivier - interfaSys sàrl 2015-10-20 11:32:53 UTC
@Kubilay

No, this patch did not come from upstream. I've created it because I was facing the problem on this particular setup.

I have not tested any other FreeBSD version, so I have no idea if it fails on 10 per example.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-20 11:35:33 UTC
Thank you for the update Olivier, but the symptoms you experienced were definitely build failures on 9.3 with GCC 4.9? Did you try any other compilers, or versions of GCC?
Comment 5 Olivier - interfaSys sàrl 2015-10-20 12:00:03 UTC
I didn't try any other compilers, no. I've tried different linkers (gold, bfd).

The only other compilers I have would be the one from base, but I'm not sure it's a good comparison.
Comment 6 m.tsatsenko 2015-10-20 21:19:44 UTC
Hi, Oliver,
Could you please post here your /etc/make.conf contents? I will try to reproduce the problem in a clean environment.
Comment 7 Martin Wilke freebsd_committer freebsd_triage 2015-12-24 20:41:50 UTC
Timeout.