usr.sbin/makefs/cd9660/cd9660_write.c CID 975621 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR) copy_paste_error: rf in fclose(rf) looks like a copy-paste error. Should it say fd instead? 471 (void)fclose(rf); --------------- Source analysis: The suspicion stems from the assymetric reaction on error. Only the read FILE pointer rf was opened inside the function. So it gets closed in both error cases: with read FILE *rf and with write FILE *fd. if (ferror(rf)) { ... (void)fclose(rf); ... if (ferror(fd)) { ... (void)fclose(rf); --------------- Remedy proposal: In Coverity classify CID 975621 as "False positive" and set its Action to "Ignore".
Bulk taking makefs bugs.
Releasing bugs back to the pool.
Have marked this as a false positive in Coverity.