Bug 203959 - [patch] math/wcalc: Update to 2.5
Summary: [patch] math/wcalc: Update to 2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-10-22 13:47 UTC by Torsten Zühlsdorff
Modified: 2015-11-22 08:22 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback-


Attachments
patch with update to version 2.5 (991 bytes, patch)
2015-10-22 13:47 UTC, Torsten Zühlsdorff
no flags Details | Diff
poudriere log (18.56 KB, text/x-log)
2015-10-22 13:47 UTC, Torsten Zühlsdorff
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2015-10-22 13:47:00 UTC
Created attachment 162356 [details]
patch with update to version 2.5

Hello,

attached a patch does:
- update the port to current version 2.5
- removes unneeded DISTNAME definition
- adds License

Greetings,
Torsten
Comment 1 Torsten Zühlsdorff 2015-10-22 13:47:40 UTC
Created attachment 162357 [details]
poudriere log
Comment 2 commit-hook freebsd_committer 2015-11-22 08:04:24 UTC
A commit references this bug:

Author: danfe
Date: Sun Nov 22 08:03:52 UTC 2015
New revision: 402219
URL: https://svnweb.freebsd.org/changeset/ports/402219

Log:
  - Update to version 2.5
  - Define LICENSE (GPLv2), switch to USES=localbase
  - Drop redundant DISTNAME and CONFIGURE_ARGS assignments
  - Remove old-school attribution from pkg-descr

  PR:		203959 (modified)
  Approved by:	maintainer timeout (33 days)

Changes:
  head/math/wcalc/Makefile
  head/math/wcalc/distinfo
  head/math/wcalc/pkg-descr
Comment 3 Alexey Dokuchaev freebsd_committer 2015-11-22 08:22:41 UTC
Thank you for the patch.  I've committed slightly different version though, because:

- You forgot to remove redundant DISTNAME (default value it is)
- COPYING file is a standard boilerplace and does not contain any copyright information, hence I didn't define LICENSE_FILE
- USES=localbase allows us to drop explicit amendment of CFLAGS/LDFLAGS
- Old-school attribution should be removed from pkg-descr

Note for the future: just asserting that poudriere build is OK is enough; no need to attach an actual log.  No one ever reads them and all they do is clog Bugzilla.