Bug 203981 - [patch] lang/nim: Update to 0.11.2
Summary: [patch] lang/nim: Update to 0.11.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mathieu Arnold
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-10-23 12:35 UTC by Torsten Zühlsdorff
Modified: 2015-10-28 12:58 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+

Attachments
patch with update to 0.11.2 (6.39 KB, patch)
2015-10-23 12:35 UTC, Torsten Zühlsdorff 		koobs: maintainer-approval+
Details | Diff
poudriere log (401.35 KB, text/x-log)
2015-10-23 12:36 UTC, Torsten Zühlsdorff 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2015-10-23 12:35:58 UTC 
Created attachment 162391 [details]
patch with update to 0.11.2

Hello,

attached a patch to update the port to the current version 0.11.2. While there:
- recreate patches with make makepatch
- remove PORTREVISION=0
- rework the COMMENT a little
-> short: make portlint happy

Greetings,
Torsten
Comment 1 Torsten Zühlsdorff 2015-10-23 12:36:18 UTC 
Created attachment 162392 [details]
poudriere log
Comment 2 Torsten Zühlsdorff 2015-10-23 12:52:22 UTC 
Add dependency to 200935 even if the PRs are just related to another. Dependency provides an old patch, which is similar to mine. My patch does the some but also respects the new qa-standards of portlint.
Comment 3 Neal Nelson 2015-10-28 10:59:57 UTC 
This patch seems OK, supplanting my old one which langushed for some time
in the database.

I don't see the reason for the change in the comment however. It is
"The" Nim language after all. The article is required in English.

Other than that, all is good.
Comment 4 Torsten Zühlsdorff 2015-10-28 11:03:33 UTC 
(In reply to Neal Nelson from comment #3)

> I don't see the reason for the change in the comment however. 
> It is "The" Nim language after all. The article is required in English.

The change was done to pet portlint. Thats the only reason for the rework and could be undone. 

Should i undone it?

If you are fine with the patch please set the maintainer-flag. If you want me do change the comment back please set the feedback to "-" and i will update the patch. :)

Greetings,
Torsten
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-28 11:10:11 UTC 
The <title> of the nim-lang.org homeage is "Nim Programming Language" and is consistent with COMMENT standards of not using a leading indefinite article. 

In this case the modified COMMENT is valid (and is substantiated by upstream language).

@Torsten, please use See Also for issues that refer to this or are related to other issues. Depends/Blocks is exactly and only for when listed issues MUST be resolved prior to, or after this one, respectively.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-28 11:11:30 UTC 
Comment on attachment 162391 [details]
patch with update to 0.11.2

Maintainer approved in commetn 3, with committer follow up to confirm COMMENT change. This patch is good to go.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-10-28 12:58:19 UTC 
A commit references this bug:

Author: mat
Date: Wed Oct 28 12:57:47 UTC 2015
New revision: 400388
URL: https://svnweb.freebsd.org/changeset/ports/400388

Log:
  Update to 0.11.2

  PR:		203981
  Submitted by:	Torsten Z?hlsdorff
  Approved by:	maintainer
  Sponsored by:	Absolight

Changes:
  head/lang/nim/Makefile
  head/lang/nim/distinfo
  head/lang/nim/pkg-plist