Bug 204038 - [MAINTAINER][PATCH] www/calendarserver incompatible with databases/sqlparse-0.1.16
Summary: [MAINTAINER][PATCH] www/calendarserver incompatible with databases/sqlparse-0...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-10-26 15:07 UTC by Axel.Rau
Modified: 2015-10-26 21:04 UTC (History)
1 user (show)

See Also:


Attachments
patch against revision 400186 (1.43 KB, patch)
2015-10-26 15:07 UTC, Axel.Rau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Axel.Rau 2015-10-26 15:07:29 UTC
Created attachment 162473 [details]
patch against revision 400186

After upgrade databases/sqlparse from 0.1.2_1 to 0.1.16, caldavd crashes during startup:
- - -
 File "/usr/local/lib/python2.7/site-packages/twext/enterprise/dal/parseschema.py", line 544, in expectSingle
    (nextval.__class__.__name__, nextval))
twext.enterprise.dal.parseschema.ViolatedExpectation: Expected <class 'sqlparse.sql.Parenthesis'> got Comment:<Comment '-- imp...' at 0x809a649e0>
/usr/local/etc/rc.d/caldavd: WARNING: failed to start caldavd
- - -

Attached patch, based on work from amaramrahul@users.sourceforge.net, fixes it.

poudriere testport run successfully on 10.1.
Comment 1 Kurt Jaeger freebsd_committer 2015-10-26 18:22:19 UTC
Testing soon on a test host near to you 8-)
Comment 2 Kurt Jaeger freebsd_committer 2015-10-26 20:33:05 UTC
One little issue:

Warning: 'lib/python2.7/site-packages/twext/python/sendmsg.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Comment 3 commit-hook freebsd_committer 2015-10-26 21:04:33 UTC
A commit references this bug:

Author: pi
Date: Mon Oct 26 21:03:58 UTC 2015
New revision: 400207
URL: https://svnweb.freebsd.org/changeset/ports/400207

Log:
  www/calendarserver: add patch to cope with databases/sqlparse in version 0.1.16

  PR:		204038
  Submitted by:	Axel Rau <Axel.Rau@Chaos1.DE> (maintainer)

Changes:
  head/www/calendarserver/Makefile
  head/www/calendarserver/files/patch-txdav__common__datastore__sql_schema__current.sql
Comment 4 Kurt Jaeger freebsd_committer 2015-10-26 21:04:52 UTC
Test-builds done, committed, thanks.