Bug 204050 - mail/opendmarc: needs mail/libspf2 runtime dependency
Summary: mail/opendmarc: needs mail/libspf2 runtime dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: easy, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2015-10-27 03:26 UTC by Douglas Thrift
Modified: 2015-10-28 09:11 UTC (History)
3 users (show)

See Also:
koobs: merge-quarterly+


Attachments
the output of "pkg install opendmarc", "ldd /usr/local/sbin/opendmarc", and "pkg autoremove" (1.31 KB, text/plain)
2015-10-27 03:26 UTC, Douglas Thrift
koobs: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Thrift 2015-10-27 03:26:37 UTC
Created attachment 162490 [details]
the output of "pkg install opendmarc", "ldd /usr/local/sbin/opendmarc", and "pkg autoremove"

There seems to be a problem with the dependency on libspf2 for the
package of opendmarc: libspf2 was installed when I did a "pkg install
opendmarc", but upon inspection there does not seem to be any dependency
information registered and "pkg autoremove" removes it. Running "ldd
/usr/local/sbin/opendmarc" shows that it links to libspf2.so.2, so it
definitely needs a runtime dependency. I have attached the output of the relevant commands.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-27 05:02:12 UTC
Comment on attachment 162490 [details]
the output of "pkg install opendmarc", "ldd /usr/local/sbin/opendmarc", and "pkg autoremove"

Implicit approval (blanket)
Comment 2 commit-hook freebsd_committer 2015-10-27 05:05:06 UTC
A commit references this bug:

Author: koobs
Date: Tue Oct 27 05:04:55 UTC 2015
New revision: 400214
URL: https://svnweb.freebsd.org/changeset/ports/400214

Log:
  mail/opendmarc: Add libspf2 as a run-time (library) dependency

  libsfp2 is a build and run-time dependency for opendmarc.

  Currently libspf2 is declared a BUILD_DEPENDS, which results in the
  libspf2 package being removed by portmaster or pkg as an unecessary
  package when using -s argument or autoremove command respectively.

  This change correctly declares libspf2 as a LIB_DEPENDS, resulting
  in both build and run-time dependency registration.

  While I'm here:

   - Convert MSPF conditional to an option helper
   - Group and sort USE{S} entries
   - Whitespace align OPTIONS
   - Tweak SPF_DESC to match ./configure output for the option
   - Sort pkg-plist

  PR:		204050
  Submitted by:	Douglas <douglas douglasthrift net>
  Approved by:	portmgr (blanket)
  MFH:		2015Q4

Changes:
  head/mail/opendmarc/Makefile
  head/mail/opendmarc/pkg-plist
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-27 05:06:44 UTC
Pending portmgr approval for MFH
Comment 4 commit-hook freebsd_committer 2015-10-28 09:10:54 UTC
A commit references this bug:

Author: koobs
Date: Wed Oct 28 09:10:12 UTC 2015
New revision: 400377
URL: https://svnweb.freebsd.org/changeset/ports/400377

Log:
  MFH: r400214

  mail/opendmarc: Add libspf2 as a run-time (library) dependency

  libsfp2 is a build and run-time dependency for opendmarc.

  Currently libspf2 is declared a BUILD_DEPENDS, which results in the
  libspf2 package being removed by portmaster or pkg as an unecessary
  package when using -s argument or autoremove command respectively.

  This change correctly declares libspf2 as a LIB_DEPENDS, resulting
  in both build and run-time dependency registration.

  While I'm here:

   - Convert MSPF conditional to an option helper
   - Group and sort USE{S} entries
   - Whitespace align OPTIONS
   - Tweak SPF_DESC to match ./configure output for the option
   - Sort pkg-plist

  PR:		204050
  Submitted by:	Douglas <douglas douglasthrift net>
  Approved by:	portmgr (blanket)

  Approved by:	portmgr (feld)

Changes:
_U  branches/2015Q4/
  branches/2015Q4/mail/opendmarc/Makefile
  branches/2015Q4/mail/opendmarc/pkg-plist
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-28 09:11:43 UTC
Committed in HEAD and 2015Q4 quarterly, thanks for the report Douglas!