Bug 204092 - benchmarks/iperf3: update to 3.1
Summary: benchmarks/iperf3: update to 3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bruce A. Mah
URL:
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-10-28 14:24 UTC by Piotr Kubaj
Modified: 2015-10-29 04:27 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
iperf3 3.1 (1.01 KB, text/plain)
2015-10-28 14:24 UTC, Piotr Kubaj
koobs: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2015-10-28 14:24:21 UTC
Created attachment 162535 [details]
iperf3 3.1

The following patch updates the port to the recently released version 3.1. It builds fine on releng/10.2.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-28 14:30:28 UTC
For future ference, changes for ports go into the "Individual Ports" component, not "Ports Framework" unless its a change to Mk/* files.
Comment 2 Piotr Kubaj freebsd_committer 2015-10-28 14:32:10 UTC
(In reply to Kubilay Kocak from comment #1)
Oh, I know that, it was a kind of typo, only with a mouse :)
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-28 14:35:42 UTC
No problemo, you *should* be able to re-classify it (component, assignee) yourself if it happens again :)
Comment 4 Bruce A. Mah freebsd_committer 2015-10-29 03:07:36 UTC
With the bug in this state, am I supposed to review and commit the patch or give approval for someone else to commit it?

Either way is fine, I'm just unsure of the protocol at this point since maintainer-feedback is set to ?, I'm the owner of the bug and the port maintainer.

(And the diff looks fine, thanks for the reporter for doing this.  I should have done this myself when I did the upstream iperf3 release.)
Comment 5 commit-hook freebsd_committer 2015-10-29 04:11:07 UTC
A commit references this bug:

Author: bmah
Date: Thu Oct 29 04:10:39 UTC 2015
New revision: 400440
URL: https://svnweb.freebsd.org/changeset/ports/400440

Log:
  Update to iperf-3.1.

  PR:		204092
  Submitted by:	pkubaj at riseup dot net
  Sponsored by:	ESnet

Changes:
  head/benchmarks/iperf3/Makefile
  head/benchmarks/iperf3/distinfo
Comment 6 Bruce A. Mah freebsd_committer 2015-10-29 04:12:10 UTC
Ah nevermind, I just committed it after a brief test.  Fixed in r400440.

Closing as FIXED, thanks again for the patch and reminder.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-29 04:27:31 UTC
If/Since you're the maintainer, you may/should set the flag to + to avoid feedback/maintainer timeouts (and thus someone else being able to take/commit :)

Also set the attachment maintainer-approval flag to + if you approve patches