Created attachment 163066 [details]
Also fixed SPACE->TAB in MAKE_ARGS=.
To be clear, this header contains some byte-wise operations that users who manipulate colors will tend to use, and include.
So IMO it is good to have this header as part of provided include files.
Created attachment 163069 [details]
Hi, I'm not convinced we should do this. I looked at debian and fedora and neither installs the header you proposing. It also might not be a "public" header otherwise pixman would install the header already.
I don't have string feelings about this one, however I think that this is reasonable for someone working with pixel data to desire to include pixman-combine32.h.
I asked on pixman mailing list if they would agree to make it public.
We should stick to upstream. This header is cleanly internal, it doesn't even have include guards, and it defines macros with explicitly generic names (like MASK) which will cause conflicts. Application requiting it from pixman are broken, though they may bundle it.
This makes it aligned and look cleaner. Is number of tabs standardized anywhere?
This comment isn't for this bug.
It looks like pixman people don't care to answer.