Bug 204508 - x11/pixman: added pixman-combine32.h to plist that is used by some other packages
Summary: x11/pixman: added pixman-combine32.h to plist that is used by some other pack...
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks: 204497
  Show dependency treegraph
 
Reported: 2015-11-12 19:17 UTC by Yuri Victorovich
Modified: 2015-12-04 03:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
patch (1.03 KB, patch)
2015-11-12 19:17 UTC, Yuri Victorovich
no flags Details | Diff
poudriere log (33.41 KB, text/plain)
2015-11-12 19:38 UTC, Yuri Victorovich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2015-11-12 19:17:15 UTC
Created attachment 163066 [details]
patch

Also fixed SPACE->TAB in MAKE_ARGS=.
Comment 1 Yuri Victorovich freebsd_committer 2015-11-12 19:26:33 UTC
To be clear, this header contains some byte-wise operations that users who manipulate colors will tend to use, and include.

So IMO it is good to have this header as part of provided include files.
Comment 2 Yuri Victorovich freebsd_committer 2015-11-12 19:38:13 UTC
Created attachment 163069 [details]
poudriere log
Comment 3 Koop Mast freebsd_committer 2015-11-18 19:05:35 UTC
Hi, I'm not convinced we should do this. I looked at debian and fedora and neither installs the header you proposing. It also might not be a "public" header otherwise pixman would install the header already.
Comment 4 Yuri Victorovich freebsd_committer 2015-11-20 07:29:47 UTC
Koop,

I don't have string feelings about this one, however I think that this is reasonable for someone working with pixel data to desire to include pixman-combine32.h.

I asked on pixman mailing list if they would agree to make it public.

Yuri
Comment 5 Dmitry Marakasov freebsd_committer 2015-12-02 19:39:42 UTC
We should stick to upstream. This header is cleanly internal, it doesn't even have include guards, and it defines macros with explicitly generic names (like MASK) which will cause conflicts. Application requiting it from pixman are broken, though they may bundle it.
Comment 6 Yuri Victorovich freebsd_committer 2015-12-02 20:02:42 UTC
Why?
This makes it aligned and look cleaner. Is number of tabs standardized anywhere?
Comment 7 Yuri Victorovich freebsd_committer 2015-12-02 20:03:29 UTC
This comment isn't for this bug.
Comment 8 Yuri Victorovich freebsd_committer 2015-12-04 03:06:17 UTC
It looks like pixman people don't care to answer.