Created attachment 163086 [details] patch with update to 1.23.1 Hello, attached a patch to bring the port to its current version. portlint -C is fine. poudriere test-builds are fine for: 9.3 amd64 + i386 10.1 amd64 + i386 10.2 amd64 + i386 11-current r290639 amd64 + i386 I use the software in my own progress. As runtime test i installed the new version and check if everything works like expected - it did :) Greetings, Torsten
Suggestion for commit message: Log: www/pecl-twig: update 1.23.0 -> 1.23.1 Changes: * 1.23.1 (2015-11-05) * fixed some exception messages which triggered PHP warnings * fixed BC on Twig_Test_NodeTestCase PR: 204517 Submitted by: Torsten Zühlsdorff <ports@toco-domains.de> (maintainer)
Nice work Torsten. Don't forge tto set maintainer-approval to + for ports you maintain or patches you approve (as maintainer)
(In reply to Kubilay Kocak from comment #2) > Don't forge tto set maintainer-approval to + for ports you maintain > or patches you approve (as maintainer) Originally i wanted to ask why this is needed, but after some thoughts i have so much possible answers, that i've set the flags for the new PRs. :) But one question left: Is maintainer-approval for the patch enough? Or is maintainer-feedback + also needed?
A commit references this bug: Author: sunpoet Date: Fri Nov 13 19:14:07 UTC 2015 New revision: 401551 URL: https://svnweb.freebsd.org/changeset/ports/401551 Log: - Update to 1.23.1 Changes: https://github.com/twigphp/Twig/blob/1.x/CHANGELOG PR: 204517 Submitted by: Torsten Zuhlsdorff <ports@toco-domains.de> (maintainer) Changes: head/www/pecl-twig/Makefile head/www/pecl-twig/distinfo
Committed. Thanks!