Bug 204547 - www/npm: fixed default C/C++ compiler in node-gyp gcc -> cc, g++ -> c++, added gmake dependency
Summary: www/npm: fixed default C/C++ compiler in node-gyp gcc -> cc, g++ -> c++, adde...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords: needs-qa, patch
Depends on:
Blocks: 204932 204578 204906 204907 205053
  Show dependency tree / graph
 
Reported: 2015-11-14 19:55 UTC by Yuri Victorovich
Modified: 2015-12-06 17:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)
koobs: merge-quarterly?

Attachments
patch (1.05 KB, patch)
2015-11-14 19:55 UTC, Yuri Victorovich 		no flags Details | Diff
patch (1.44 KB, patch)
2015-11-14 20:10 UTC, Yuri Victorovich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2015-11-14 19:55:25 UTC 
Created attachment 163124 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2015-11-14 20:10:36 UTC 
Created attachment 163125 [details]
patch

Added gmake runtime dependency, because gyp runs gmake during module 'install' command.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-06 17:52:24 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Dec  6 17:52:06 UTC 2015
New revision: 403137
URL: https://svnweb.freebsd.org/changeset/ports/403137

Log:
  - Add gmake to RUN_DEPENDS
  - Fix default C/C++ compiler in node-gyp
  - Bump PORTREVISION for dependency and package change

  PR:		204547
  Submitted by:	Yuri <yuri@rawbw.com>

Changes:
  head/www/npm/Makefile
  head/www/npm/files/patch-node_modules-node-gyp-gyp-pylib-gyp-generator-make.py
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-12-06 17:55:29 UTC 
Committed. Thanks!