Bug 204552 - security/openct: Don't truncate received APDU when talking to pcsc-lite 1.8.14
Summary: security/openct: Don't truncate received APDU when talking to pcsc-lite 1.8.14
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alex Dupre
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-11-15 00:34 UTC by Marcin Cieślak
Modified: 2017-04-10 12:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ale)
koobs: merge-quarterly?

Attachments
Bump PORTREVISION to 2 (2.18 KB, patch)
2015-11-15 00:34 UTC, Marcin Cieślak 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Cieślak 2015-11-15 00:34:20 UTC 
Created attachment 163130 [details]
Bump PORTREVISION to 2

pcsc-lite starting from 1.8.14 provides 65548 byte
receive buffers to IFDHTransmitToICC(), which is
a maximal extended APDU size. Unfortunately this
is more than CT API can use (16 bits).

If more than 65536 bytes are about to be sent,
return IFD_PROTOCOL_NOT_SUPPORTED.

Receive at most 65536 bytes. pcsc-lite will always
specify 65548 buffer, even if the client application
requests less; therefore we cannot return an error
in this case.

Discussion:
https://lists.alioth.debian.org/pipermail/pcsclite-muscle/Week-of-Mon-20151109/000493.html

Also submitted as:

https://github.com/OpenSC/openct/pull/5
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-04-10 12:15:16 UTC 
A commit references this bug:

Author: ale
Date: Mon Apr 10 12:14:50 UTC 2017
New revision: 438157
URL: https://svnweb.freebsd.org/changeset/ports/438157

Log:
  Don't truncate received APDU when talking to pcsc-lite.

  PR:		204552
  Submitted by:	Marcin Cieslak <saper@saper.info>

Changes:
  head/security/openct/Makefile
  head/security/openct/files/patch-src_pcsc_pcsc.c