Bug 204608 - net-mgmt/collectd5 : wrong depends for XML
Summary: net-mgmt/collectd5 : wrong depends for XML
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Unovitch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-16 19:36 UTC by Henrik Hudson
Modified: 2015-11-17 00:59 UTC (History)
2 users (show)

See Also:
ports: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Hudson 2015-11-16 19:36:55 UTC
The Makefile for the newly updated port looks like it has a copy / paste issue.

XML_LIB_DEPENDS=                libxmms.so:${PORTSDIR}/multimedia/xmms
XML_CONFIGURE_WITH=             libxml2=${LOCALBASE}

XMMS_CFLAGS=                    `xmms-config --cflags`
XMMS_LIB_DEPENDS=               libxmms.so:${PORTSDIR}/multimedia/xmms
XMMS_CONFIGURE_ENABLE=          xmms
XMMS_CONFIGURE_WITH=            libxmms=${LOCALBASE}


I'm guessing the XML_LIB_DEPENDS= should be:

XML_LIB_DEPENDS=  libxml2.so:${PORTSDIR}/textproc/libxml2
Comment 1 Krzysztof 2015-11-16 22:07:31 UTC
Yes, of course. It's my typo during converting Makefile to new framework. Thank you very much for your checking.
Comment 2 commit-hook freebsd_committer 2015-11-17 00:57:49 UTC
A commit references this bug:

Author: junovitch
Date: Tue Nov 17 00:57:09 UTC 2015
New revision: 401796
URL: https://svnweb.freebsd.org/changeset/ports/401796

Log:
  net-mgmt/collectd5: fix typo and add patch for Varnish 4.1 compatability

  - Fix copy/paste typo in XML_LIB_DEPENDS [1]
  - Add patch for building with varnish4-4.1 and drop VARNISH_BROKEN [2]
  - Bump PORTREVISION for package change with XML_LIB_DEPENDS option

  PR:		204608 [1]
  PR:		204583 [2]
  Reported by:	rhavenn@rhavenn.net [1]
  Submitted by:	feld [2]
  Obtained from:	https://github.com/mfournier/collectd [2]
  Approved by:	Krzysztof <ports@bsdserwis.com> (maintainer)

Changes:
  head/net-mgmt/collectd5/Makefile
  head/net-mgmt/collectd5/files/patch-src__varnish.c
Comment 3 Jason Unovitch freebsd_committer 2015-11-17 00:59:41 UTC
(In reply to rhavenn from comment #0)
Thank you!

Sorry for not catching this during the initial conversion.  This is fixed now.