Bug 204708 - Mk/bsd.option.mk: variable expansion difference between _(ON|OFF) and _(WITH|ENABLE)
Summary: Mk/bsd.option.mk: variable expansion difference between _(ON|OFF) and _(WITH|...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: https://lists.freebsd.org/pipermail/f...
Keywords: dogfood, needs-qa, patch
Depends on:
Blocks: 204220
  Show dependency tree / graph
 
Reported: 2015-11-21 03:21 UTC by Jason Unovitch
Modified: 2015-12-29 18:53 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (portmgr)
koobs: merge-quarterly?

Attachments
bsd.option.mk incomplete patch as there're more cases with premature expansion (2.21 KB, patch)
2015-11-21 03:23 UTC, Jason Unovitch 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Unovitch freebsd_committer freebsd_triage 2015-11-21 03:21:14 UTC 
Further discussion is in mailing list thread in URL.

...
PERL_CONFIGURE_WITH=            perl=${PERL} perl-bindings
...
PYTHON_CONFIGURE_WITH=          python=${PYTHON_CMD}

% make -VPERL_CONFIGURE_WITH
perl=/usr/local/bin/perl perl-bindings
% make -VPYTHON_CONFIGURE_WITH
python=/usr/local/bin/python2.7

However, for CONFIGURE_ARGS the ${PERL} and ${PYTHON_CMD} variables are
getting swallowed up.  The port will fail to compile because of this.

% make -VCONFIGURE_ARGS
"--enable-python --with-python= "
"--enable-perl --with-perl= --with-perl-bindings"

Blocks fully converting net-mgmt/collectd5 to option helpers (bug 204220)
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-11-21 03:22:48 UTC 
Add jbeich@ to CC before adding his in progress patch (thanks again Jan!).
Comment 2 Jason Unovitch freebsd_committer freebsd_triage 2015-11-21 03:23:34 UTC 
Created attachment 163363 [details]
bsd.option.mk incomplete patch as there're more cases with premature expansion
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-12-29 16:46:30 UTC 
Fixed by ports r404759. Re-open if you think otherwise. MFH may not be required as 2016Q1 branch date should be in a few days...
Comment 4 Jason Unovitch freebsd_committer freebsd_triage 2015-12-29 18:53:37 UTC 
(In reply to Jan Beich from comment #3)
Thank you Jan.  I concur, with 2016Q1 days away I see no pressing need for MFH and I won't be MFH'ing the option helper conversion in dependent bug 204220 that required this anyway.