Bug 204721 - databases/php56-redis: Update to 2.2.7
Summary: databases/php56-redis: Update to 2.2.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-11-21 21:08 UTC by m.tsatsenko
Modified: 2015-12-10 14:30 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
patch (1.26 KB, text/plain)
2015-11-21 21:08 UTC, m.tsatsenko 		no flags Details
updated patch (1.39 KB, patch)
2015-11-27 21:01 UTC, m.tsatsenko 		m.tsatsenko: maintainer-approval+
Details | Diff
patch (1.39 KB, patch)
2015-12-08 22:16 UTC, m.tsatsenko 		m.tsatsenko: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description m.tsatsenko 2015-11-21 21:08:49 UTC 
Created attachment 163385 [details]
patch

- Update to 2.2.7
- Convert to option helpers

QA: http://pkg.tsatsenko.ru/logs/bulk/93amd64-default/2015-11-22_00h05m03s/logs/php56-redis-2.2.7.log
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-22 02:18:31 UTC 
The rest of:

.if ${PORT_OPTIONS:MIGBINARY}

Can be converted into an OPTIONS helper as well, removing the need for:

.include bsd.port.options.mk

Please also set maintainer-approval to + on any attachments you approve (including those you author yourself)

Thanks!
Comment 2 m.tsatsenko 2015-11-27 21:01:27 UTC 
Created attachment 163596 [details]
updated patch

Hi, Thanks for feedback!

Revised patch attached.

QA: http://pkg.tsatsenko.ru/logs/bulk/93amd64-default/2015-11-27_23h57m55s/logs/php56-redis-2.2.7.log
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2015-11-30 16:04:10 UTC 
Take.
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2015-12-05 18:10:55 UTC 
Hi,

IGBINARY_CONFIGURE_ENABLE=        redis-igbinary
IGBINARY_USE=                        php=redis

this looks wrong to me, also when you enable it, it fails.
Comment 5 m.tsatsenko 2015-12-08 22:16:12 UTC 
Created attachment 164003 [details]
patch

Fixed a typo.
Now it builds fine with IGBINARY enabled: http://pkg.tsatsenko.ru/logs/bulk/102amd64-default/2015-12-09_01h11m59s/logs/php56-redis-2.2.7.log
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-12-10 14:30:53 UTC 
A commit references this bug:

Author: miwi
Date: Thu Dec 10 14:30:00 UTC 2015
New revision: 403460
URL: https://svnweb.freebsd.org/changeset/ports/403460

Log:
  - Update to 2.2.7
  - Switch to options helper

  PR: 	204721
  Submitted by:	maintainer
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D4334

Changes:
  head/databases/php56-redis/Makefile
  head/databases/php56-redis/distinfo