Bug 204749 - [patch] Don't (try to) build qlxbge if the user objects to binary blobs
Summary: [patch] Don't (try to) build qlxbge if the user objects to binary blobs
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Ed Maste
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-11-22 16:17 UTC by Fabian Keil
Modified: 2018-05-23 14:00 UTC (History)
1 user (show)

See Also:

Attachments
sys/modules: Don't (try to) build qlxbge if the user objects to binary blobs (766 bytes, patch)
2015-11-22 16:17 UTC, Fabian Keil 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2015-11-22 16:17:35 UTC 
Created attachment 163434 [details]
sys/modules: Don't (try to) build qlxbge if the user objects to binary blobs

The qlxbge module contains source-less microcode but is built and
installed even if WITHOUT_SOURCELESS_UCODE is set.

The attached patch fixes this.

Obtained from: ElectroBSD
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-08-19 01:12:57 UTC 
A commit references this bug:

Author: emaste
Date: Sat Aug 19 01:12:05 UTC 2017
New revision: 322684
URL: https://svnweb.freebsd.org/changeset/base/322684

Log:
  sys/modules: don't build qlxgbe if the user objects to sourceless ucode

  PR:		204749
  Submitted by:	Fabian Keil
  Obtained from:	ElectroBSD
  MFC after:	1 week

Changes:
  head/sys/modules/Makefile
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2018-05-23 10:27:57 UTC 
batch change of PRs untouched in 2018 marked "in progress" back to open.
Comment 3 Ed Maste freebsd_committer freebsd_triage 2018-05-23 14:00:41 UTC 
Merged to stable/11 in r322916 and stable/10 in r334096