Bug 204757 - [PATCH] deskutils/taskd: Add rc.d script, pkg-message, and taskd user
Summary: [PATCH] deskutils/taskd: Add rc.d script, pkg-message, and taskd user
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steven Kreuzer
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-11-23 01:57 UTC by Ike Eichorn
Modified: 2017-03-10 22:45 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (skreuzer)


Attachments
Preliminary patch (3.10 KB, patch)
2015-11-23 01:57 UTC, Ike Eichorn
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ike Eichorn 2015-11-23 01:57:45 UTC
Created attachment 163443 [details]
Preliminary patch

Taskd is a server/daemon and could use a rc.d script to start at boot.

After consulting with the maintainer, I have come up with a preliminary patch to add a basic rc.d script, taskd, and it is attached to this PR.

Since taskd uses a self-signed X509 certificate authority, it requires significant user configuration. As the rc.d script does not perfectly integrate with upstream's configuration instructions, a pkg-message is provided to instruct the user.

KNOWN PROBLEMS WITH PATCH:
1) Does not include modifications to ports/UIDs and ports/GIDs to add taskd user and group. (I couldn't figure out how (new to svn))

2) portslint had concerns with paths in pkg-message, I don't know what to do.

3) I could not figure out how to improve permissions handling with the unprivileged user (TASKDDATA directory and /var/log/taskd.log). This would be a substantial improvement, but in lieu of it the pkg-message provides instructions to modify the permissions.

4) There is a prexisting problem (CHMOD) that portslint has detected.

5) This is my first ever patch to anything, please review CAREFULLY.
Comment 1 commit-hook freebsd_committer 2016-08-11 16:07:32 UTC
A commit references this bug:

Author: skreuzer
Date: Thu Aug 11 16:06:52 UTC 2016
New revision: 420083
URL: https://svnweb.freebsd.org/changeset/ports/420083

Log:
  Add a rc script and have taskd run as an unprivileged user

  PR:		204757
  Submitted by:	Ike Eichorn <ike@michaeleichorn.com>

Changes:
  head/GIDs
  head/UIDs
  head/deskutils/taskd/Makefile
  head/deskutils/taskd/files/
  head/deskutils/taskd/files/taskd.in
  head/deskutils/taskd/pkg-message
  head/deskutils/taskd/pkg-plist