Bug 204765 - net/tshark fails to build since 2.0
Summary: net/tshark fails to build since 2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-23 10:58 UTC by Sergey Akhmatov
Modified: 2015-11-23 15:55 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
poudriere build log (214.17 KB, text/x-log)
2015-11-23 10:58 UTC, Sergey Akhmatov 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Akhmatov 2015-11-23 10:58:52 UTC 
Created attachment 163455 [details]
poudriere build log

net/tshark does not build since version 2.0

gmake[6]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0/doc'
gmake[5]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0/doc'
gmake[4]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0'
gmake[3]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0'
gmake[2]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0'
/bin/mv /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark-gtk  /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark
mv: /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark-gtk: No such file or directory
*** Error code 1

poudriere log attached.
Comment 1 elofu17 2015-11-23 14:41:05 UTC 
Same error for me.


...
...
gmake[1]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0'
/bin/mv /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark-gtk  /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark
mv: /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark-gtk: No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/net/tshark
====>> Cleaning up wrkdir
===>  Cleaning for tshark-2.0.0
build of net/tshark ended at Mon Nov 23 11:58:10 CET 2015
build time: 00:10:09
!!! build failure encountered !!!
Comment 2 elofu17 2015-11-23 14:58:49 UTC 
If it has any relevance (I see "gtk" in the filename), I've disabled X11 in my make.conf :

CFLAGS= -O2
NO_GUI=true
NO_GAMES=true
NO_PROFILE=true
OPTIONS_UNSET=X11
WITH_PKGNG=yes
WITHOUT_CHECK=yes
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-11-23 15:02:39 UTC 
A commit references this bug:

Author: marcus
Date: Mon Nov 23 15:01:42 UTC 2015
New revision: 402278
URL: https://svnweb.freebsd.org/changeset/ports/402278

Log:
  Be a bit more selective with the port-install to fix tshark.

  PR:		204765

Changes:
  head/net/wireshark/Makefile
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2015-11-23 15:03:31 UTC 
Fixed.  I made this change-last minute after I did the tshark test.  Forgot that QT5 off meant the no GUI case, too.
Comment 5 Sergey Akhmatov 2015-11-23 15:40:22 UTC 
Build succeedes, make install or make package fails:

===>  Building package for tshark-2.0.0
pkg-static: Unable to access file /usr/ports/net/tshark/work/stage/usr/local/%%GUI_GTK%%share/applications/wireshark-gtk.desktop: No such file or directory
*** Error code 1

Seems like problem with plist
GUI_GTK remains unset in case neither of GTK2, GTK3 and QT5 is selected
Comment 6 Sergey Akhmatov 2015-11-23 15:49:15 UTC 
Patch fixes things for me:

--- Makefile    (revision 402278)
+++ Makefile    (working copy)
@@ -128,6 +128,7 @@
     empty(PORT_OPTIONS:MQT5)
 CONFIGURE_ARGS+=       --disable-wireshark
 PLIST_SUB+=            GUI="@comment "
+PLIST_SUB+=            GUI_GTK="@comment "
 .else
 USES+=                 desktop-file-utils shared-mime-info
 INSTALLS_ICONS=                yes
Comment 7 Joe Marcus Clarke freebsd_committer freebsd_triage 2015-11-23 15:55:56 UTC 
Sorry, meant to add this macro.