Bug 204819 - [PATCH] security/sshpass: new feature, backport upstream patch
Summary: [PATCH] security/sshpass: new feature, backport upstream patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-11-25 20:35 UTC by Andrey Fesenko
Modified: 2016-01-02 12:09 UTC (History)
4 users (show)

See Also:
riggs: maintainer-feedback-
riggs: merge-quarterly-

Attachments
patch-Makefile and add files patchs (5.28 KB, patch)
2015-11-25 20:35 UTC, Andrey Fesenko 		koobs: maintainer-approval? (gaod)
 Details | Diff
poudriere bulk -t log (15.31 KB, text/plain)
2015-11-25 20:35 UTC, Andrey Fesenko 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Fesenko 2015-11-25 20:35:11 UTC 
Created attachment 163535 [details]
patch-Makefile and add files patchs

Standart login ssh promt see:
Password:
password:

sshpass hardcoded "assword:", FreeBSD sshd (pam) return "Password for user@host.local:", last tow patch in upstream add new key -P for custom password string.

Small Makefile fix, add USES autoreconf, need for build.
Comment 1 Andrey Fesenko 2015-11-25 20:35:50 UTC 
Created attachment 163536 [details]
poudriere bulk -t log
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2015-11-25 20:45:23 UTC 
testbuilds fine on 11-amd64, 10.2a+i, 9.3a.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2015-11-25 20:47:23 UTC 
See

https://lists.freebsd.org/pipermail/freebsd-stable/2015-November/083710.html

for context and pointers to related problem reports with salt, ansible.
Comment 4 Hung-Yi Chen 2015-11-27 07:12:03 UTC 
Hmm...I'll test it.
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2015-12-24 21:16:57 UTC 
Hi,

Any update here?
Comment 6 Thomas Zander freebsd_committer freebsd_triage 2016-01-02 11:52:40 UTC 
Maintainer timeout
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-01-02 12:00:44 UTC 
A commit references this bug:

Author: riggs
Date: Sat Jan  2 11:59:59 UTC 2016
New revision: 405067
URL: https://svnweb.freebsd.org/changeset/ports/405067

Log:
  Backport patch from upstream trunk for 'hangs forever' issue

  On http://sourceforge.net/p/sshpass/bugs/12/ the issue is explained:
  Doing a "sshpass -p password ssh vmfreebsd10-32 -l account ls" hangs
  forever.  The reason is that in this combination the prompt for the
  password looks like this: "Password for account@vmfreebsd10-32:" and
  sshpass checks the password against the string "assword:", so there
  is no match.

  This is fixed upstream in trunk, but no release has been created yet.
  Import the patch into the ports tree until the next release.

  PR:		204819
  Submitted by:	andrey@bsdnir.info
  Approved by:	maintainer timeout

Changes:
  head/security/sshpass/Makefile
  head/security/sshpass/files/
  head/security/sshpass/files/patch-configure.ac
  head/security/sshpass/files/patch-main.c
  head/security/sshpass/files/patch-sshpass.1
  head/security/sshpass/pkg-descr
Comment 8 Thomas Zander freebsd_committer freebsd_triage 2016-01-02 12:09:39 UTC 
No quarterly merge since 2016Q1 branch is around the corner and this patch will be included.