Bug 204948 - [NEW PORT] games/openmw: Unofficial open source engine reimplementation of the game Morrowind
Summary: [NEW PORT] games/openmw: Unofficial open source engine reimplementation of th...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: feature, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-12-01 22:15 UTC by Tobias Kortkamp
Modified: 2015-12-02 22:47 UTC (History)
1 user (show)

See Also:


Attachments
openmw.shar (22.91 KB, text/plain)
2015-12-01 22:15 UTC, Tobias Kortkamp
no flags Details
Poudriere log FreeBSD 10.2/amd64 (171.97 KB, text/x-log)
2015-12-01 22:16 UTC, Tobias Kortkamp
no flags Details
Poudriere log FreeBSD 10.2/amd64 (171.30 KB, text/x-log)
2015-12-01 23:55 UTC, Tobias Kortkamp
no flags Details
openmw.shar (22.54 KB, text/plain)
2015-12-01 23:58 UTC, Tobias Kortkamp
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2015-12-01 22:15:08 UTC
Created attachment 163727 [details]
openmw.shar

OpenMW is a recreation of the engine for the popular role-playing game
Morrowind by Bethesda Softworks.  You need to own and install the
original game for OpenMW to work.

WWW: https://openmw.org

----

This port does not currently build OpenCS (the game's editor) because I support only Qt 5 in this port and graphics/osg currently has only a Qt 4 option.  This is something to be added later when graphics/osg can support Qt 5.
Comment 1 Tobias Kortkamp freebsd_committer 2015-12-01 22:16:15 UTC
Created attachment 163728 [details]
Poudriere log FreeBSD 10.2/amd64
Comment 2 Dmitry Marakasov freebsd_committer 2015-12-01 23:07:39 UTC
From the first glance:

- Please fix data install location to use ${DATADIR} instead of share/games/openmw, should be as easy as patching away "games/" with REINPLACE_CMD (could set GLOBAL_DATA_PATH instead, but games/ is hardcoded in another place)
- Please add LICENSE_FILE
- WWW:, not being a plain file, should end with a slash
- No need for += in CMAKE_ARGS
- Better to silence strip (@${STRIP_CMD} ...)
- Fails to build on 9.x:

/wrkdirs/usr/ports/games/openmw/work/openmw-openmw-0.37.0/./components/files/configurationmanager.hpp:55: error: ISO C++ forbids declaration of 'unordered_map' with no type

You should add compiler:c++11-lib to uses, but it still should be just marked broken on 9.x with BROKEN_FreeBSD_9= does not build, as it'll hit ABI incompatibility with depends.

Do you plan to upstream the patches?
Comment 3 Tobias Kortkamp freebsd_committer 2015-12-01 23:55:36 UTC
Created attachment 163731 [details]
Poudriere log FreeBSD 10.2/amd64
Comment 4 Tobias Kortkamp freebsd_committer 2015-12-01 23:58:30 UTC
Created attachment 163732 [details]
openmw.shar

Thanks.  Here is an updated port.  Solved the data dir issue by setting a bunch of CMake variables. Where else did you see games/?

And yes I plan to upstream most of the patches eventually.
Comment 5 Dmitry Marakasov freebsd_committer 2015-12-02 11:38:52 UTC
Works great, ready to commit. One last thing: you specify t@tobik.me as MAINTAINER, however you bugzilla account uses tobias.kortkamp@gmail.com. These should generally match, otherwise maintainer approvals won't work and there may be other complications.
Comment 6 Tobias Kortkamp freebsd_committer 2015-12-02 11:44:42 UTC
Ok, I did not know that this was a problem. I changed my Bugzilla email address to t@tobik.me.
Comment 7 Dmitry Marakasov freebsd_committer 2015-12-02 13:51:45 UTC
(In reply to Tobias Kortkamp from comment #6)
> Ok, I did not know that this was a problem. I changed my Bugzilla email
> address to t@tobik.me.

Ok, should I change it in other ports maintained by tobias.kortkamp@gmail.com then?
Comment 8 commit-hook freebsd_committer 2015-12-02 13:52:33 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Dec  2 13:52:24 UTC 2015
New revision: 402826
URL: https://svnweb.freebsd.org/changeset/ports/402826

Log:
  OpenMW is a recreation of the engine for the popular role-playing game
  Morrowind by Bethesda Softworks.  You need to own and install the
  original game for OpenMW to work.

  WWW: https://openmw.org/

  PR:		204948
  Submitted by:	t@tobik.me

Changes:
  head/games/Makefile
  head/games/openmw/
  head/games/openmw/Makefile
  head/games/openmw/distinfo
  head/games/openmw/files/
  head/games/openmw/files/patch-CMakeLists.txt
  head/games/openmw/files/patch-apps_essimporter_converter.hpp
  head/games/openmw/files/patch-apps_openmw_crashcatcher.cpp
  head/games/openmw/files/patch-apps_openmw_engine.cpp
  head/games/openmw/files/patch-apps_openmw_mwinput_inputmanagerimp.cpp
  head/games/openmw/files/patch-apps_openmw_mwmechanics_spells.cpp
  head/games/openmw/files/patch-apps_openmw_mwmechanics_spells.hpp
  head/games/openmw/files/patch-apps_openmw_mwworld_refdata.hpp
  head/games/openmw/files/patch-apps_openmw_mwworld_weather.cpp
  head/games/openmw/files/patch-apps_openmw_mwworld_worldimp.cpp
  head/games/openmw/files/patch-apps_wizard_CMakeLists.txt
  head/games/openmw/files/patch-components_esm_spellstate.cpp
  head/games/openmw/files/patch-components_esm_spellstate.hpp
  head/games/openmw/files/patch-components_files_configurationmanager.hpp
  head/games/openmw/files/patch-components_sceneutil_lightcontroller.cpp
  head/games/openmw/files/patch-files_gamecontrollerdb.txt
  head/games/openmw/pkg-descr
  head/games/openmw/pkg-message
  head/games/openmw/pkg-plist
Comment 9 Tobias Kortkamp freebsd_committer 2015-12-02 13:59:57 UTC
(In reply to Dmitry Marakasov from comment #7)
Sure, more recently submitted ports already use t@tobik.me.  I thought changing the MAINTAINER line can wait until I actually have an update to the ports.

Thanks for committing OpenMW so quickly! :)
Comment 10 commit-hook freebsd_committer 2015-12-02 22:47:39 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Dec  2 22:47:16 UTC 2015
New revision: 402862
URL: https://svnweb.freebsd.org/changeset/ports/402862

Log:
  - Update maintainer's email in 3 port

  PR:		204948

Changes:
  head/deskutils/easystroke/Makefile
  head/lang/chibi-scheme/Makefile
  head/sysutils/acerhdf-kmod/Makefile
Comment 11 commit-hook freebsd_committer 2015-12-02 22:47:40 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Dec  2 22:47:16 UTC 2015
New revision: 47817
URL: https://svnweb.freebsd.org/changeset/doc/47817

Log:
  - Update email of Tobias Kortkamp

  PR:		204948

Changes:
  head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml