Bug 204995 - devel/cgit: Add USE_OPENSSL (missing dependency)
Summary: devel/cgit: Add USE_OPENSSL (missing dependency)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords: easy, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2015-12-03 15:18 UTC by Adam Weinberger
Modified: 2015-12-07 03:59 UTC (History)
1 user (show)

See Also:
kevinz5000: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2015-12-03 15:18:43 UTC 
cgit will link against openssl/libressl in ${LOCALBASE}, but doesn't register any dependency.

The port Makefile should define USE_OPENSSL=yes to get that dependency.

Kevin, do you have any objection to this?
Comment 1 Kevin Zheng 2015-12-03 22:27:40 UTC 
Thanks for catching this issue; no objections.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-07 03:58:16 UTC 
A commit references this bug:

Author: adamw
Date: Mon Dec  7 03:58:06 UTC 2015
New revision: 403176
URL: https://svnweb.freebsd.org/changeset/ports/403176

Log:
  cgit will link against libcrypto in ${LOCALBASE} if it exists, so
  add USE_OPENSSL to acknowledge the dependency.

  PR:		204995
  Approved by:	Kevin Zheng (maintainer)

Changes:
  head/devel/cgit/Makefile
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2015-12-07 03:59:29 UTC 
Committed, along with a PORTREVISION bump for the dependency change.

Thanks for such a fast review, Kevin!