Bug 205036 - [PATCH][build] remove redundant check of the DEBUG_FLAGS in bsd.prog.mk
Summary: [PATCH][build] remove redundant check of the DEBUG_FLAGS in bsd.prog.mk
Status: Closed Not Accepted
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-12-05 13:12 UTC by Alexander Kuleshov
Modified: 2022-12-13 14:34 UTC (History)
7 users (show)

See Also:

Attachments
Remove redundant check of the DEBUG_FLAGS (535 bytes, patch)
2015-12-05 13:12 UTC, Alexander Kuleshov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kuleshov 2015-12-05 13:12:14 UTC 
Created attachment 163866 [details]
Remove redundant check of the DEBUG_FLAGS

Hello,

This patch removes redundant check of the DEBUG_FLAGS in the bsd.prog.mk. We already check it above in the same file, so we no need to check it again.
Comment 1 kate john 2017-08-18 08:03:09 UTC 
MARKED AS SPAM
Comment 2 Dhruv Day 2018-12-27 04:30:30 UTC 
MARKED AS SPAM
Comment 3 KuchJano 2019-02-02 06:36:22 UTC 
MARKED AS SPAM
Comment 4 manan 2019-02-08 18:06:38 UTC 
MARKED AS SPAM
Comment 5 vocok 2019-02-12 18:58:32 UTC 
MARKED AS SPAM
Comment 6 wuninaz 2019-02-19 09:59:24 UTC 
MARKED AS SPAM
Comment 7 jokebos 2019-02-26 05:58:38 UTC 
MARKED AS SPAM
Comment 8 SahibKumarKhan 2019-04-08 15:56:45 UTC 
MARKED AS SPAM
Comment 9 SahibKumarKhan 2019-04-08 15:56:54 UTC 
MARKED AS SPAM
Comment 10 SahibKumarKhan 2019-04-08 15:57:03 UTC 
MARKED AS SPAM
Comment 11 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-04-17 20:59:13 UTC 
But if MK_CTF is "no", then we would not set STRIP. I am not sure if that's correct.

I'll close the PR for now. Please reopen it if I misunderstood the patch.

Cheers!
Comment 12 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-04-17 21:00:13 UTC 
Of course I read it incorrectly. Sorry about that. I'm reopening this PR.
Comment 13 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-04-17 21:06:08 UTC 
https://reviews.freebsd.org/D29814
Comment 14 Mateusz Piotrowski freebsd_committer freebsd_triage 2022-12-13 14:34:48 UTC 
I don't think it is necessary to commit this style patch. The current version is readable. At the same time, the proposed change introduces a potentially confusing else statement, which has to be clarified with a comment.