Bug 205300 - mail/dkimproxy: Add IPv6 support, Take MAINTAINER'ship
Summary: mail/dkimproxy: Add IPv6 support, Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-13 21:36 UTC by Andrey Fesenko
Modified: 2015-12-16 06:30 UTC (History)
1 user (show)

See Also:

Attachments
patch-Makefile and files (5.45 KB, patch)
2015-12-13 21:36 UTC, Andrey Fesenko 		koobs: maintainer-approval+
Details | Diff
poudriere bulk -t log (17.66 KB, text/plain)
2015-12-13 21:37 UTC, Andrey Fesenko 		no flags Details
patch-Makefile and files (5.49 KB, patch)
2015-12-14 01:59 UTC, Andrey Fesenko 		koobs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Fesenko 2015-12-13 21:36:51 UTC 
Created attachment 164208 [details]
patch-Makefile and files

Porting patches https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656041 and add IPv6 option for port

root@110amd64-default-dkimproxy:/usr/ports/mail/dkimproxy # portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: new ports should not be maintained by ports@FreeBSD.org.
0 fatal errors and 3 warnings found.
Comment 1 Andrey Fesenko 2015-12-13 21:37:54 UTC 
Created attachment 164209 [details]
poudriere bulk -t log
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-14 00:25:39 UTC 
Thanks Andrey

The if ${PORT_OPTIONS:MIPV6} block can be converted to use OPTIONS helpers.

Should IPV6 option be made OPTIONS_DEFAULT? (out of the box feature for package)

Feel free to also take MAINTAINER'ship of this port, as it is currently unmaintained
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-14 00:25:53 UTC 
Comment on attachment 164208 [details]
patch-Makefile and files

Port is unmaintained, implicit approval
Comment 4 Andrey Fesenko 2015-12-14 01:59:11 UTC 
Created attachment 164217 [details]
patch-Makefile and files

Fix port option OPT_USE style, set himself MAINTAINER
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-14 02:06:57 UTC 
Comment on attachment 164217 [details]
patch-Makefile and files

Port is unmaintained, implicit approval
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-12-15 18:48:28 UTC 
A commit references this bug:

Author: pi
Date: Tue Dec 15 18:47:49 UTC 2015
New revision: 403798
URL: https://svnweb.freebsd.org/changeset/ports/403798

Log:
  mail/dkimproxy: Add IPv6 support, submitter takes MAINTAINER

  See also:
    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656041

  PR:		205300
  Submitted by:	Andrey Fesenko <andrey@bsdnir.info>
  Reviewed by:	koobs

Changes:
  head/mail/dkimproxy/Makefile
  head/mail/dkimproxy/files/extra-patch-lib-MSDW-SMTP-Server.pm
  head/mail/dkimproxy/files/extra-patch-scripts-dkimproxy.out
  head/mail/dkimproxy/files/extra-patch-scripts-dkimproxy_in.conf.example
  head/mail/dkimproxy/files/extra-patch-scripts-dkimproxy_out.conf.example
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2015-12-15 18:50:33 UTC 
Test-builds done, all fine. Committed, thanks!