Bug 205436 - games/minecraft-client: Fix dependencies
Summary: games/minecraft-client: Fix dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Unovitch
URL:
Keywords: easy, patch, patch-ready
Depends on: 205435
Blocks:
  Show dependency tree / graph
 
Reported: 2015-12-19 20:35 UTC by Ilia Skalozubov
Modified: 2015-12-25 02:17 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (1.18 KB, patch)
2015-12-19 20:35 UTC, Ilia Skalozubov 		vlad-fbsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilia Skalozubov 2015-12-19 20:35:04 UTC 
Created attachment 164390 [details]
file.diff

Added dependency on libopenal.so (fix no sound)
Fixed dependency on lwjgl-2.9.3 (Bug 205435)
Comment 1 VK 2015-12-19 23:16:22 UTC 
Comment on attachment 164390 [details]
file.diff

The port has no maintainer, implicit approval of the patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-25 02:13:12 UTC 
A commit references this bug:

Author: junovitch
Date: Fri Dec 25 02:13:04 UTC 2015
New revision: 404400
URL: https://svnweb.freebsd.org/changeset/ports/404400

Log:
  games/minecraft-client: update dependencies

  - Add libopenal.so as a LIB_DEPENDS to resolve run time issue (no sound)
  - Update LWJGL lib dependency to 2.9.3
  - Add NO_ARCH while here

  PR:		205436
  Submitted by:	Ilia Skalozubov <freebsd@skinc.ru>

Changes:
  head/games/minecraft-client/Makefile
  head/games/minecraft-client/files/minecraft-runtime
Comment 3 Jason Unovitch freebsd_committer freebsd_triage 2015-12-25 02:17:31 UTC 
Committed to go with bug 205435. Thanks!

However, we can probably do this better.  Can you submit another PR to fix all the hard coded '/usr/local' occurrences to %%PREFIX%% and do substitution on those scripts?  Also does LWJGL_JLP_OVRD have to be defined in that shell script?  Can we find it dynamically?