Bug 205498 - multimedia/ffmpeg: Rename option "LIBV4L" to "V4L"
Summary: multimedia/ffmpeg: Rename option "LIBV4L" to "V4L"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks: 205499
  Show dependency tree / graph
 
Reported: 2015-12-21 21:25 UTC by Yuri Victorovich
Modified: 2015-12-24 12:51 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)

Attachments
patch (1.50 KB, patch)
2015-12-21 21:25 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2015-12-21 21:25:35 UTC 
Created attachment 164471 [details]
patch

Every other port uses V4L.

It is beneficial when the user sets one default V4L=on and all relevant ports will switch to V4L support.
Comment 1 Chris Hutchinson 2015-12-21 22:59:12 UTC 
(In reply to yuri from comment #0)
> Created attachment 164471 [details]
> patch
> 
> Every other port uses V4L.
> 
> It is beneficial when the user sets one default V4L=on and all relevant
> ports will switch to V4L support.

Hey Yuri. :)

I see you pulled the LIBV4l description:
-LIBV4L_DESC=	Video for Linux support

But didn't replace it with anything.
Maybe:

+V4L_DESC=	Video for Linux support ?

But maybe it's just me. :)

--Chris
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-12-21 23:39:37 UTC 
There is the default description for V4L.
Comment 3 Chris Hutchinson 2015-12-22 00:11:29 UTC 
(In reply to yuri from comment #2)
> There is the default description for V4L.

Ahh... Sorry. My bad.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-12-24 12:48:33 UTC 
A commit references this bug:

Author: riggs
Date: Thu Dec 24 12:47:59 UTC 2015
New revision: 404350
URL: https://svnweb.freebsd.org/changeset/ports/404350

Log:
  Update to upstream version 2.8.4

  While on it:
  - Rename option "LIBV4L" to "V4L" to match naming as in other ports [1]

  PR:		205498 [1]
  Submitted by:	yuri@rawbw.com [1]

Changes:
  head/multimedia/ffmpeg/Makefile
  head/multimedia/ffmpeg/distinfo
  head/multimedia/ffmpeg/files/patch-libavcodec-libvpxenc.c