205581 – games/megaglest-data Update to 3.12.0, Take MAINTAINER'ship

Bug 205581 - games/megaglest-data Update to 3.12.0, Take MAINTAINER'ship

Summary: games/megaglest-data Update to 3.12.0, Take MAINTAINER'ship

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Dmitry Marakasov

URL:
Keywords:	needs-qa, patch

Depends on:
Blocks:	205485
	Show dependency tree / graph

Reported:	2015-12-24 15:45 UTC by Thibault Payet
Modified:	2016-04-23 00:20 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
is the shar (2.60 KB, text/plain) 2015-12-24 15:45 UTC, Thibault Payet	no flags	Details
megaglest-data.shar (2.52 KB, text/plain) 2015-12-26 10:05 UTC, Thibault Payet	koobs: maintainer-approval+	Details
megaglest-data.shar (2.52 KB, text/plain) 2015-12-26 10:45 UTC, Thibault Payet	no flags	Details
megaglest-data.shar (2.48 KB, text/plain) 2015-12-26 17:42 UTC, Thibault Payet	no flags	Details
megaglest-data diff (2.12 KB, patch) 2015-12-26 19:23 UTC, Thibault Payet	no flags	Details \| Diff
poudriere testport log : megaglest-data-3.12.0 (995.52 KB, text/plain) 2016-03-26 15:37 UTC, Thibault Payet	no flags	Details
svn diff of megaglest 3.12.0 (407.26 KB, patch) 2016-03-26 15:39 UTC, Thibault Payet	no flags	Details \| Diff
megaglest-data.diff updated (406.32 KB, patch) 2016-03-27 12:30 UTC, Thibault Payet	no flags	Details \| Diff
megaglest-data poudriere testport log (994.79 KB, text/x-log) 2016-03-27 12:59 UTC, Thibault Payet	no flags	Details
megaglest-data diff (1.34 KB, patch) 2016-04-02 14:32 UTC, Thibault Payet	no flags	Details \| Diff
megaglest data diff (1.96 KB, patch) 2016-04-02 15:47 UTC, Thibault Payet	no flags	Details \| Diff
the poudriere testport log (10.52 KB, text/x-log) 2016-04-02 15:48 UTC, Thibault Payet	no flags	Details
megaglest data diff (2.08 KB, patch) 2016-04-02 17:37 UTC, Thibault Payet	no flags	Details \| Diff
poudriere testport log (10.70 KB, text/x-log) 2016-04-03 08:25 UTC, Thibault Payet	no flags	Details
Show Obsolete (12) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thibault Payet 2015-12-24 15:45:56 UTC

Created attachment 164602 [details]
is the shar

Here is a shar to upgrade to 3.11.1

Comment 1 Thibault Payet 2015-12-26 10:05:36 UTC

Created attachment 164663 [details]
megaglest-data.shar

Add me to maintainer

Comment 2 Kubilay Kocak freebsd_committer

2015-12-26 10:15:13 UTC

@monwarez Can you confirm this passes QA (portlint, poudriere) please

Comment 3 Kubilay Kocak freebsd_committer

2015-12-26 10:15:30 UTC

Comment on attachment 164663 [details]
megaglest-data.shar

Port is unmaintained, implicit approval

Comment 4 Thibault Payet 2015-12-26 10:45:43 UTC

Created attachment 164670 [details]
megaglest-data.shar

Pass the portlint test

Comment 5 Thibault Payet 2015-12-26 17:42:39 UTC

Created attachment 164697 [details]
megaglest-data.shar

Pass the poudriere testport

Comment 6 Thibault Payet 2015-12-26 19:23:36 UTC

Created attachment 164700 [details]
megaglest-data diff

megaglest-data diff it pass QA (portlint , poudriere)

Comment 7 Thibault Payet 2016-03-26 15:37:00 UTC

Created attachment 168651 [details]
poudriere testport log : megaglest-data-3.12.0

Comment 8 Thibault Payet 2016-03-26 15:39:13 UTC

Created attachment 168652 [details]
svn diff of megaglest 3.12.0

Notice: the diff was done with megaglest-data-3.9.0

Comment 9 Dmitry Marakasov freebsd_committer

2016-03-27 01:10:59 UTC

Sorry for delay - I've jsut committed 3.11.1 patch, please resubmit the update against it.

Comment 10 commit-hook freebsd_committer

2016-03-27 01:11:10 UTC

A commit references this bug:

Author: amdmi3
Date: Sun Mar 27 01:10:13 UTC 2016
New revision: 411968
URL: https://svnweb.freebsd.org/changeset/ports/411968

Log:
  - Update to 3.11.1
  - Cleanup the port
  - Pass maintainership to submitter

  PR:		205581
  Submitted by:	monwarez@mailoo.org

Changes:
  head/games/megaglest-data/Makefile
  head/games/megaglest-data/distinfo

Comment 11 Thibault Payet 2016-03-27 12:30:55 UTC

Created attachment 168680 [details]
megaglest-data.diff updated

For megaglest-data, I prefer to use cmake for installing data, If you think it's too much dependency tell me. Poudriere log will come ASAP

Comment 12 Thibault Payet 2016-03-27 12:59:12 UTC

Created attachment 168682 [details]
megaglest-data poudriere testport log

Comment 13 Dmitry Marakasov freebsd_committer

2016-04-01 19:28:38 UTC

Please keep using PORTDATA=*. Data files make plist too large, and there's no reason for that.

Comment 14 Dmitry Marakasov freebsd_committer

2016-04-01 19:34:19 UTC

Also, why are you removing docs? Licenses should be converted to license framework though.

Comment 15 Thibault Payet 2016-04-02 14:32:19 UTC

Created attachment 168891 [details]
megaglest-data diff

I just added the .desktop to be installed

Comment 16 Thibault Payet 2016-04-02 14:46:48 UTC

For unknown reason , the .desktop are not installed

Comment 17 Thibault Payet 2016-04-02 15:47:27 UTC

Created attachment 168895 [details]
megaglest data diff

Now it should work

Comment 18 Thibault Payet 2016-04-02 15:48:14 UTC

Created attachment 168896 [details]
the poudriere testport log

Comment 19 Thibault Payet 2016-04-02 17:37:00 UTC

Created attachment 168903 [details]
megaglest data diff

Add megaglest.png on share/pixmaps (megaglest.ico may not work if ico is not supported)

Comment 20 Thibault Payet 2016-04-03 08:25:11 UTC

Created attachment 168920 [details]
poudriere testport log

Comment 21 commit-hook freebsd_committer

2016-04-23 00:20:05 UTC

A commit references this bug:

Author: amdmi3
Date: Sat Apr 23 00:19:32 UTC 2016
New revision: 413799
URL: https://svnweb.freebsd.org/changeset/ports/413799

Log:
  - Update to 3.12.0

  PR:		205581
  Submitted by:	monwarez@mailoo.org (maintainer)

Changes:
  head/games/megaglest-data/Makefile
  head/games/megaglest-data/distinfo
  head/games/megaglest-data/pkg-plist