Bug 205721 - usr/src/sys/mips/rt305x/rt305x_spi.c:250: possible missing break ?
Summary: usr/src/sys/mips/rt305x/rt305x_spi.c:250: possible missing break ?
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-30 10:09 UTC by David Binderman
Modified: 2019-01-16 01:33 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2015-12-30 10:09:51 UTC 
[usr/src/sys/mips/rt305x/rt305x_spi.c:250] -> [usr/src/sys/mips/rt305x/rt305x_spi.c:252]: (warning) Variable 'tx_cmd_sz' is reassigned a value before the old one has been used. 'break;' missing?

                case CMD_READ:
                        cmd->tx_cmd_sz = 4;
                case CMD_FAST_READ:
                        cmd->tx_cmd_sz = 5;
                        cmd->rx_cmd_sz = cmd->tx_data_sz = 0;
                        break;
Comment 1 Michael Zhilin freebsd_committer freebsd_triage 2016-03-22 12:02:34 UTC 
Hi,

Any progress with ticket? Is there any patch? 

Thx!
Comment 2 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-16 01:33:50 UTC 
The file was deleted as part of base r327457 (unifying Mediatek code under sys/mips/mediatek)